Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): update node styles #7321

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

BiswaViraj
Copy link
Member

@BiswaViraj BiswaViraj commented Dec 18, 2024

What changed? Why was the change needed?

Screenshots

image

fixed with padding:
image

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

linear bot commented Dec 18, 2024

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit 54fca3c
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/6762acaf2a401e00089b1bcb
😎 Deploy Preview https://deploy-preview-7321.dashboard.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for dashboard-v2-novu-staging ready!

Name Link
🔨 Latest commit 54fca3c
🔍 Latest deploy log https://app.netlify.com/sites/dashboard-v2-novu-staging/deploys/6762acaf9dc3230008c95845
😎 Deploy Preview https://deploy-preview-7321.dashboard-v2.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -66,7 +66,7 @@ export const NodeBody = ({ children }: { children: ReactNode }) => {
<span className="text-foreground-400 overflow-hidden text-ellipsis text-nowrap text-sm font-medium">
{children}
</span>
<span className="to-background/90 absolute left-0 top-0 h-full w-full bg-gradient-to-r from-[rgba(255,255,255,0.00)] from-70% to-95%" />
<span className="to-background/90 absolute left-0 top-0 h-full w-full rounded-b-[calc(var(--radius)-1px)] bg-gradient-to-r from-[rgba(255,255,255,0.00)] from-70% to-95%" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the -1px ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because the outer container has 1px padding,so (outer radius - padding) = inner radius

@BiswaViraj BiswaViraj merged commit 56bd9ec into next Dec 18, 2024
38 checks passed
@BiswaViraj BiswaViraj deleted the nv-4932-redo-the-select-state-for-step-in-the-canvas branch December 18, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants