feat(dashboard): new integrations page view #7310
Conversation
❌ Deploy Preview for dashboard-v2-novu-staging failed. Why did it fail? →
|
…/novuhq/novu into feat-new-integrations-page-table
| @@ -0,0 +1,117 @@ | |||
| import { Badge } from '@/components/primitives/badge'; | |||
There was a problem hiding this comment.
Please move all the component files from the src/pages/integrations/components directory to the src/components/integrations. If the utils are reusable between the modules please move them to the utils folder, otherwise, keep them under the src/components/integrations.
There was a problem hiding this comment.
Oh my 🤦♂️ was prototyping initially and forgot to move them. I blame keyboard shortcuts for this hehe
There was a problem hiding this comment.
Going to address this in the second PR to avoid merge conflict from hell
apps/dashboard/src/pages/integrations/integrations-list-page.tsx
Outdated
Show resolved
Hide resolved
apps/dashboard/src/pages/integrations/components/integrations-list.tsx
Outdated
Show resolved
Hide resolved
apps/dashboard/src/pages/integrations/components/integrations-list.tsx
Outdated
Show resolved
Hide resolved
apps/dashboard/src/pages/integrations/components/integrations-list.tsx
Outdated
Show resolved
Hide resolved
apps/dashboard/src/pages/integrations/components/integration-card.tsx
Outdated
Show resolved
Hide resolved
apps/dashboard/src/pages/integrations/components/integration-card.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| <div className="mt-auto flex items-center gap-2"> | ||
| {integration.channel === 'in_app' && !integration.connected ? ( | ||
| <Button size="xs" className="h-[26px]" variant="outline" onClick={handleConfigureClick}> |
There was a problem hiding this comment.
if that's the size we would like to use, let's introduce it to the button component
There was a problem hiding this comment.
It's not a size that will be used outside of this component. @twentyone24 I've added this Configure button on the In App provider in case the user hasn't connected yet the integration. Any suggestions on other UX pattern for it? I had to adjust the button size to be in the same size of the Env pill
apps/dashboard/src/pages/integrations/components/integration-card.tsx
Outdated
Show resolved
Hide resolved
apps/dashboard/src/pages/integrations/components/integration-card.tsx
Outdated
Show resolved
Hide resolved
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer