fix(dashboard): Fix stale data on test workflow page #7245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desiprisg
force-pushed
the
nv-4847-step-editor-refresh-need-to-get-the-new-payload-variables
branch
from
ecb497a to
d437c11
Compare
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
desiprisg
force-pushed
the
nv-4847-step-editor-refresh-need-to-get-the-new-payload-variables
branch
from
d437c11 to
5b19e17
Compare
SokratisVidros
approved these changes
Dec 9, 2024
| queryKey: [ | ||
| QueryKeys.fetchWorkflowTestData, | ||
| currentEnvironment?._id, | ||
| getEncodedId({ slug: workflowSlug, divider: WORKFLOW_DIVIDER }), |
There was a problem hiding this comment.
Nit-picky one:
Suggested change
| getEncodedId({ slug: workflowSlug, divider: WORKFLOW_DIVIDER }), | |
| getWorkflowInternalId(workflowSlug), |
| const { currentEnvironment } = useEnvironment(); | ||
| const { data, isPending, error } = useQuery<WorkflowTestDataResponseDto>({ | ||
| queryKey: [QueryKeys.fetchWorkflowTestData, currentEnvironment?._id, workflowSlug], | ||
| queryKey: [ |
There was a problem hiding this comment.
@desiprisg I think the test data page is better if we don't cache it at all. It's a separate tab, so I don't see the value of caching. We'd rather fetch data every time we visit the tab instead of caching and invalidating.
There was a problem hiding this comment.
Sure we can set gcTime to 0 to achieve this. queryKey remains required though, in order to trigger a refetch if an invalidation were to happen while the query is still used.
desiprisg
force-pushed
the
nv-4847-step-editor-refresh-need-to-get-the-new-payload-variables
branch
from
5b19e17 to
731e1a0
Compare
desiprisg
force-pushed
the
nv-4847-step-editor-refresh-need-to-get-the-new-payload-variables
branch
from
731e1a0 to
d153eac
Compare
desiprisg
force-pushed
the
nv-4847-step-editor-refresh-need-to-get-the-new-payload-variables
branch
from
d153eac to
143fb81
Compare
desiprisg
deleted the
nv-4847-step-editor-refresh-need-to-get-the-new-payload-variables
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer