fix(dashboard): run queue invocations safely #7243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LetItRock
reviewed
Dec 9, 2024
LetItRock
reviewed
Dec 9, 2024
Comment on lines
66
to
67
| // If the invocation fails, we want to log the error and continue with the next invocation | ||
| console.error('Error processing queue item:', error); |
There was a problem hiding this comment.
I'm not sure if the console.error brings any value here.
There was a problem hiding this comment.
I agree, we can remove it.
SokratisVidros
approved these changes
Dec 9, 2024
Comment on lines
66
to
67
| // If the invocation fails, we want to log the error and continue with the next invocation | ||
| console.error('Error processing queue item:', error); |
There was a problem hiding this comment.
I agree, we can remove it.
LetItRock
approved these changes
Dec 9, 2024
ChmaraX
deleted the
nv-4986-dashboard-error-state-if-put-workflows-fail-the-page-stop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
API errors would result in client freezing, due to unhandled error state.
Simulating 0.33 error rate from API:
invocations.mov