fix(dashboard): nested payload gen #7240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
djabarovgeorge
commented
Dec 8, 2024
Comment on lines
137
to
149
| const examplePayloadSchema = createMockObjectFromSchema( | ||
| { | ||
| type: 'object', | ||
| properties: { payload: workflow.payloadSchema }, | ||
| }, | ||
| true | ||
| ); | ||
|
|
||
| if (!examplePayloadSchema || Object.keys(examplePayloadSchema).length === 0) { | ||
| return finalPayload; | ||
| } | ||
|
|
||
| return _.merge( | ||
| finalPayload as Record<string, unknown>, | ||
| { payload: examplePayloadSchema }, | ||
| commandVariablesExample || {} | ||
| ); | ||
| return _.merge(finalPayload as Record<string, unknown>, examplePayloadSchema, commandVariablesExample || {}); |
There was a problem hiding this comment.
the change was needed because now createMockObjectFromSchema is a more generic function and not payload object based.
djabarovgeorge
commented
Dec 8, 2024
There was a problem hiding this comment.
was moved to shared and refactored to be a more generic function and not payload object based.
djabarovgeorge
commented
Dec 8, 2024
There was a problem hiding this comment.
was deleted, less is more?
now we reuse the createMockObjectFromSchema from shared the same one that BE used.
djabarovgeorge
commented
Dec 8, 2024
There was a problem hiding this comment.
util from the API.
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
@novu/client
@novu/framework
@novu/headless
@novu/node
@novu/notification-center
novu
@novu/providers
@novu/shared
commit: |
SokratisVidros
approved these changes
Dec 9, 2024
…load-gen # Conflicts: # apps/dashboard/src/components/workflow-editor/test-workflow/test-workflow-tabs.tsx
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Dashboard Workflow
Before
After
Framework workflow
Before
After
Empty state case
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer