Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): allow empty email preview #7239

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

djabarovgeorge
Copy link
Contributor

What changed? Why was the change needed?

before
https://www.loom.com/share/ad31b21b3db84a6ba25f3de92270e54d

after
https://www.loom.com/share/411bf3d059b245bdb527fb48b8cacd4b

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

netlify bot commented Dec 8, 2024

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit 13fc751
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/6756a447d002be0008b093f8
😎 Deploy Preview https://deploy-preview-7239.dashboard.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 8, 2024

Deploy Preview for dashboard-v2-novu-staging ready!

Name Link
🔨 Latest commit 13fc751
🔍 Latest deploy log https://app.netlify.com/sites/dashboard-v2-novu-staging/deploys/6756a447809b840008c865c7
😎 Deploy Preview https://deploy-preview-7239.dashboard-v2.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@djabarovgeorge djabarovgeorge merged commit 4df7970 into next Dec 9, 2024
30 checks passed
@djabarovgeorge djabarovgeorge deleted the fix-allow-preview-of-empty-email-state branch December 9, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants