Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(js): Remove @novu/shared dependency" #7206

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

scopsy
Copy link
Contributor

@scopsy scopsy commented Dec 3, 2024

Reverts #6906

Copy link

github-actions bot commented Dec 3, 2024

Hey there and thank you for opening this pull request! 👋

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Your PR title is: Revert "fix(js): Remove @novu/shared dependency"
It should be something like: feat(scope): Add fancy new feature

Details:

No release type found in pull request title "Revert "fix(js): Remove @novu/shared dependency"". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:

  • feat: A new feature
  • fix: A bug fix
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
  • ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for dashboard-v2-novu-staging ready!

Name Link
🔨 Latest commit f4a2de5
🔍 Latest deploy log https://app.netlify.com/sites/dashboard-v2-novu-staging/deploys/674f717cd5bd8c0008ec0845
😎 Deploy Preview https://deploy-preview-7206.dashboard-v2.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit f4a2de5
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/674f717c4650b60008bc4ff2
😎 Deploy Preview https://deploy-preview-7206.dashboard.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@scopsy scopsy merged commit adde8dd into next Dec 3, 2024
15 of 17 checks passed
@scopsy scopsy deleted the revert-6906-remove_shared_from_js branch December 3, 2024 21:01
SokratisVidros added a commit that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant