refactor(api): generate payload in runtime #7192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
commented
Dec 3, 2024
apps/api/src/app/workflows-v2/usecases/build-test-data/build-workflow-test-data.usecase.ts
Outdated
Show resolved
Hide resolved
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
commented
Dec 4, 2024
apps/api/src/app/workflows-v2/usecases/generate-preview/generate-preview.usecase.ts
Show resolved
Hide resolved
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
requested changes
Dec 5, 2024
There was a problem hiding this comment.
Nicely done @djabarovgeorge. I added some nitty gritty comments that should be easily addressed but overall the flow is crystal clear.
apps/api/src/app/workflows-v2/usecases/build-payload-schema/build-payload-schema.usecase.ts
Outdated
Show resolved
Hide resolved
apps/api/src/app/workflows-v2/usecases/build-payload-schema/build-payload-schema.usecase.ts
Show resolved
Hide resolved
apps/api/src/app/workflows-v2/usecases/build-payload-schema/build-payload-schema.usecase.ts
Outdated
Show resolved
Hide resolved
apps/api/src/app/workflows-v2/usecases/build-payload-schema/build-payload-schema.usecase.ts
Outdated
Show resolved
Hide resolved
apps/api/src/app/workflows-v2/usecases/build-payload-schema/build-payload-schema.usecase.ts
Outdated
Show resolved
Hide resolved
| * { | ||
| * validVariables: ['user.name'], | ||
| * invalidVariables: [{ | ||
| * context: '>> 1| {{invalid..syntax}}\n ^', |
There was a problem hiding this comment.
Do we need the context key in invalidVariables?
There was a problem hiding this comment.
In my opinion, we could benefit from it. this is how the CLI presents the issues.
Let me provide an example or given example:
context: '>> 1| {{invalid..syntax}}\n ^',
the client will have the exact place where the issue is if it is render/split by a new line
>> 1| {{invalid..syntax}}
^
this is an indication that Liquid JS sees an error
apps/api/src/app/workflows-v2/util/template-parser/parser-types.ts
Outdated
Show resolved
Hide resolved
apps/api/src/app/workflows-v2/util/template-parser/parser-types.ts
Outdated
Show resolved
Hide resolved
djabarovgeorge
commented
Dec 5, 2024
apps/api/src/app/workflows-v2/util/template-parser/liquid-parser.ts
Outdated
Show resolved
Hide resolved
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/novu/issue/NV-4938/calculate-payload-schema-for-the-dashboard-preview-and-trigger-pages
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer