-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api): centralize upsert validation + improve nested error handling #7173
base: next
Are you sure you want to change the base?
fix(api): centralize upsert validation + improve nested error handling #7173
Conversation
feat(api): add upsert validation
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@novu/client
@novu/framework
@novu/headless
@novu/js
@novu/nextjs
@novu/node
@novu/notification-center
novu
@novu/providers
@novu/react
@novu/react-native
@novu/shared
commit: |
@@ -72,7 +72,7 @@ export function toWorkflowsMinifiedDtos(templates: NotificationTemplateEntity[]) | |||
} | |||
|
|||
function toStepResponseDto(persistedStep: NotificationStepEntity): StepResponseDto { | |||
const stepName = persistedStep.name || 'Missing Name'; | |||
const stepName = persistedStep.name || 'Missing Name || UPDATE IMMEDIATELY'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be here, either that or an exception in case of missing name, the entity allows missing names, but our API no more @SokratisVidros
feat(api): add upsert validation
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer