-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Fix previous steps #6905
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rifont
reviewed
Nov 8, 2024
rifont
reviewed
Nov 8, 2024
apps/api/src/app/workflows-v2/shared/map-step-type-to-result.mapper.ts
Outdated
Show resolved
Hide resolved
rifont
reviewed
Nov 8, 2024
@novu/client
@novu/nest
@novu/js
@novu/headless
@novu/nextjs
@novu/framework
@novu/node
@novu/notification-center
novu
@novu/providers
@novu/react
@novu/react-native
@novu/shared
@novu/stateless
commit: |
rifont
reviewed
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Just a few tidy up comments to address
rifont
approved these changes
Nov 8, 2024
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SokratisVidros
approved these changes
Nov 9, 2024
tatarco
force-pushed
the
fix-previous-steps
branch
from
November 11, 2024 06:47
74c8988
to
0a4cc64
Compare
tatarco
force-pushed
the
fix-previous-steps
branch
from
November 11, 2024 09:12
ef5a413
to
3c71872
Compare
tatarco
force-pushed
the
fix-previous-steps
branch
from
November 12, 2024 08:07
25fed94
to
5db1401
Compare
SokratisVidros
approved these changes
Nov 12, 2024
bug(api): api compiles bug(api): tests passing
tatarco
force-pushed
the
fix-previous-steps
branch
from
November 12, 2024 11:42
48cf5ea
to
479a8b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Complete the support for previous steps
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer