-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api): bug bash preview issues resolved #6904
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tatarco
force-pushed
the
add-empty-placeholder-issue
branch
from
November 11, 2024 13:31
200af3c
to
0a708b0
Compare
@novu/client
@novu/framework
@novu/headless
@novu/js
@novu/nest
@novu/nextjs
@novu/node
@novu/notification-center
novu
@novu/providers
@novu/react
@novu/react-native
@novu/shared
@novu/stateless
commit: |
tatarco
force-pushed
the
add-empty-placeholder-issue
branch
from
November 12, 2024 08:26
fbe3ad1
to
2ff01e9
Compare
tatarco
force-pushed
the
add-empty-placeholder-issue
branch
from
November 12, 2024 08:47
f0d73e9
to
8011b6c
Compare
tatarco
force-pushed
the
add-empty-placeholder-issue
branch
from
November 12, 2024 10:38
5432f16
to
fbdd55b
Compare
tatarco
force-pushed
the
add-empty-placeholder-issue
branch
from
November 12, 2024 11:56
fbdd55b
to
d15751a
Compare
tatarco
force-pushed
the
add-empty-placeholder-issue
branch
from
November 14, 2024 11:32
8967100
to
72c5d45
Compare
tatarco
force-pushed
the
add-empty-placeholder-issue
branch
from
November 14, 2024 11:42
72c5d45
to
2376d44
Compare
tatarco
force-pushed
the
add-empty-placeholder-issue
branch
from
November 14, 2024 11:54
2376d44
to
1cc7aa1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
During the bug bash the preview endpoint appeared to be very fragile, attempt to make it more robust was difficult due to the structure of the use cases, multiple linear bugs resolved + a massive cleanup and alignment to consistent company standards
what was done?
2.. {{}} failing preview
3.. Variable validation agains Available Variable schema (validate {{name}} illegal.
4.. Control values sanitation on preview ( illegal placeholders will be removed for preview but persisted along with errors in the DB to keep the UX consistent
5.. computed Payload schema is now persisted (as string ) on upsert and served from the DB on get test data
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer