Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): Autofill payload with example in step preview #6899

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

desiprisg
Copy link
Contributor

What changed? Why was the change needed?

Screenshots

Screen.Recording.2024-11-08.at.12.26.56.PM.mov
Expand for optional sections

Related enterprise PR

Special notes for your reviewer

@desiprisg desiprisg requested a review from LetItRock November 8, 2024 10:27
@desiprisg desiprisg self-assigned this Nov 8, 2024
Copy link

linear bot commented Nov 8, 2024

@@ -48,10 +54,9 @@ export const InAppEditorPreview = () => {

<CollapsibleContent className="flex flex-col gap-2 rounded-lg p-1">
<Editor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: This can be wrapped inside the formField formcontrol, you wont need the onchange, value props‏

Copy link
Contributor

@LetItRock LetItRock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
🔨 Latest commit 581e7ca
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/672df3ce2efb4f0008972961
😎 Deploy Preview https://deploy-preview-6899--novu-stg-vite-dashboard-poc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@desiprisg desiprisg force-pushed the nv-4615-step-preview-payload-data-autofill branch from 2e0bedb to 581e7ca Compare November 8, 2024 11:19
@desiprisg desiprisg merged commit 2b33848 into next Nov 8, 2024
9 of 10 checks passed
@desiprisg desiprisg deleted the nv-4615-step-preview-payload-data-autofill branch November 8, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants