Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(framework): Support Next.js 15 with Turbopack dev server #6894

Merged
merged 16 commits into from
Nov 8, 2024

Conversation

rifont
Copy link
Collaborator

@rifont rifont commented Nov 8, 2024

What changed? Why was the change needed?

  • Support Next.js 15 with Turbopack dev server
    • Removes use of node built-in modules to support Edge runtime environments. Replacements are:
      • hand-rolled isNativeError replacing the built-in node:util/types isNativeError
      • WebCrypto implementation of HMAC validation using crypto.subtle replacing the built-in node:crypto createHmac

Screenshots

Testing with Next.js 15.0.3-canary.9

> next dev --turbopack --port 4000

   ▲ Next.js 15.0.3-canary.9 (Turbopack)
   - Local:        http://localhost:4000
   - Environments: .env.local

 ✓ Starting...
 ✓ Ready in 763ms
 ○ Compiling /api/novu ...
 ✓ Compiled /api/novu in 983ms

Discovered workflowId: 'welcome-onboarding-2'
└ σ Discovered stepId: 'send-in-app'    Type: 'in_app'
 GET /api/novu?action=discover 200 in 1221ms
Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

pkg-pr-new bot commented Nov 8, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/novuhq/novu/@novu/framework@6894

commit: 52cc1ab

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
🔨 Latest commit 52cc1ab
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/672dd40849ce7e0008f7278f
😎 Deploy Preview https://deploy-preview-6894--novu-stg-vite-dashboard-poc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rifont rifont merged commit 1e319e2 into next Nov 8, 2024
37 of 40 checks passed
@rifont rifont deleted the remove-framework-node-builtins branch November 8, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants