-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Add Error Handling 2XX issues #6884
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@novu/client
@novu/headless
@novu/framework
@novu/js
@novu/nextjs
@novu/node
@novu/notification-center
novu
@novu/providers
@novu/react
@novu/react-native
@novu/shared
commit: |
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SokratisVidros
requested changes
Nov 7, 2024
apps/api/src/app/workflows-v2/exceptions/step-not-found-exception.ts
Outdated
Show resolved
Hide resolved
apps/api/src/app/workflows-v2/mappers/notification-template-mapper.ts
Outdated
Show resolved
Hide resolved
...rc/app/workflows-v2/usecases/upsert-workflow/validate-and-persist-workflow-issues.usecase.ts
Outdated
Show resolved
Hide resolved
...rc/app/workflows-v2/usecases/upsert-workflow/validate-and-persist-workflow-issues.usecase.ts
Outdated
Show resolved
Hide resolved
...rc/app/workflows-v2/usecases/upsert-workflow/validate-and-persist-workflow-issues.usecase.ts
Outdated
Show resolved
Hide resolved
tatarco
force-pushed
the
nv-4535-workflow-editor-error-handling-logic
branch
2 times, most recently
from
November 7, 2024 14:54
a753a78
to
f716da3
Compare
tatarco
force-pushed
the
nv-4535-workflow-editor-error-handling-logic
branch
from
November 7, 2024 19:32
8daacbc
to
8fe49fc
Compare
tatarco
force-pushed
the
nv-4535-workflow-editor-error-handling-logic
branch
from
November 7, 2024 19:34
8fe49fc
to
9245910
Compare
SokratisVidros
approved these changes
Nov 7, 2024
...rc/app/workflows-v2/usecases/upsert-workflow/validate-and-persist-workflow-issues.usecase.ts
Outdated
Show resolved
Hide resolved
...rc/app/workflows-v2/usecases/upsert-workflow/validate-and-persist-workflow-issues.usecase.ts
Outdated
Show resolved
Hide resolved
...rc/app/workflows-v2/usecases/upsert-workflow/validate-and-persist-workflow-issues.usecase.ts
Show resolved
Hide resolved
tatarco
force-pushed
the
nv-4535-workflow-editor-error-handling-logic
branch
from
November 7, 2024 21:58
b620680
to
da75aaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Added Issues to error handling,
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer