Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Add Error Handling 2XX issues #6884

Merged
merged 5 commits into from
Nov 7, 2024

Conversation

tatarco
Copy link
Contributor

@tatarco tatarco commented Nov 7, 2024

What changed? Why was the change needed?

Added Issues to error handling,

  1. Added issues field on the workflows.
  2. Added issues field on the steps, supports step + content.
  3. Issues are persisted as a part of the upsert so it's available in the get as well

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

linear bot commented Nov 7, 2024

Copy link

pkg-pr-new bot commented Nov 7, 2024

Open in Stackblitz

@novu/client

pnpm add https://pkg.pr.new/novuhq/novu/@novu/client@6884

@novu/headless

pnpm add https://pkg.pr.new/novuhq/novu/@novu/headless@6884

@novu/framework

pnpm add https://pkg.pr.new/novuhq/novu/@novu/framework@6884

@novu/js

pnpm add https://pkg.pr.new/novuhq/novu/@novu/js@6884

@novu/nextjs

pnpm add https://pkg.pr.new/novuhq/novu/@novu/nextjs@6884

@novu/node

pnpm add https://pkg.pr.new/novuhq/novu/@novu/node@6884

@novu/notification-center

pnpm add https://pkg.pr.new/novuhq/novu/@novu/notification-center@6884

novu

pnpm add https://pkg.pr.new/novuhq/novu@6884

@novu/providers

pnpm add https://pkg.pr.new/novuhq/novu/@novu/providers@6884

@novu/react

pnpm add https://pkg.pr.new/novuhq/novu/@novu/react@6884

@novu/react-native

pnpm add https://pkg.pr.new/novuhq/novu/@novu/react-native@6884

@novu/shared

pnpm add https://pkg.pr.new/novuhq/novu/@novu/shared@6884

commit: 7165f83

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
🔨 Latest commit 7165f83
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/672d3890dac3d6000812f3bc
😎 Deploy Preview https://deploy-preview-6884--novu-stg-vite-dashboard-poc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tatarco tatarco force-pushed the nv-4535-workflow-editor-error-handling-logic branch 2 times, most recently from a753a78 to f716da3 Compare November 7, 2024 14:54
@tatarco tatarco force-pushed the nv-4535-workflow-editor-error-handling-logic branch from 8daacbc to 8fe49fc Compare November 7, 2024 19:32
@tatarco tatarco force-pushed the nv-4535-workflow-editor-error-handling-logic branch from 8fe49fc to 9245910 Compare November 7, 2024 19:34
@tatarco tatarco merged commit fa0c234 into next Nov 7, 2024
39 of 40 checks passed
@tatarco tatarco deleted the nv-4535-workflow-editor-error-handling-logic branch November 7, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants