Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix form not dirty on image upload #5528

Merged
merged 3 commits into from
May 9, 2024

Conversation

BiswaViraj
Copy link
Member

@BiswaViraj BiswaViraj commented May 8, 2024

What changed? Why was the change needed?

  • Fix form to be dirty when an image is selected to enable the update button

  • Previously, the update button stayed in the disabled state even after an image was selected

Ticket

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

netlify bot commented May 8, 2024

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit e648eaa
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/663b9721f34b9f0008fdd9f5
😎 Deploy Preview https://deploy-preview-5528--dev-web-novu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot removed the @novu/api label May 8, 2024
Copy link

netlify bot commented May 8, 2024

Deploy Preview for novu-design ready!

Name Link
🔨 Latest commit e648eaa
🔍 Latest deploy log https://app.netlify.com/sites/novu-design/deploys/663b9721c127d30008a54905
😎 Deploy Preview https://deploy-preview-5528--novu-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@ainouzgali ainouzgali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃🏼

Copy link
Contributor

@antonjoel82 antonjoel82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BiswaViraj BiswaViraj merged commit 8ba4ef1 into next May 9, 2024
25 checks passed
@BiswaViraj BiswaViraj deleted the fix-form-not-dirty-on-image-upload branch May 9, 2024 05:16
SokratisVidros pushed a commit that referenced this pull request May 13, 2024
* fix: remove hostlist

* fix: make form dirty when image is uploaded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants