refactor: echo getting started page #5477
Conversation
davidsoderberg
commented
Apr 30, 2024
•
davidsoderberg
commented
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| value={OnboardingUseCasesTabsEnum.ECHO} | ||
| icon={<IconConnectedTv style={ICON_STYLE} />} | ||
| > | ||
| Echo Studio |
There was a problem hiding this comment.
I think we should remove Studio from here. Studio is a mere detail here. The main point is Code-First ala Echo only. Pretty sure we have adjusted this on Figma. Is that the latest copy?
There was a problem hiding this comment.
We did but Radek liked to have the studio there and now the latest is Workflows will push it when done with other changes.
There was a problem hiding this comment.
Thanks for the refactor here, David! There's a number of places that we're doing extra work in EchoTab.tsx by not using our tokens or some of the Panda utilities.
I scheduled a pair programming session after your holiday for us to refactor the component together since I think it will be easier and a good thing to record if you're okay with it! It would be helpful for me to hear any confusions or frustrations with dev with Panda so that we can document them and improve them for everyone :)
davidsoderberg
changed the base branch from
nv-3695-get-started-page-update
to
next
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
A lot of changes have happened with the page since this pr was created please see new image on top and review the new changes :) |
apps/web/src/pages/get-started/components/get-started-tabs/EchoTab.tsx
Outdated
Show resolved
Hide resolved
