feat(ws): Mount Socket.io Admin UI #5435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LetItRock
approved these changes
Apr 19, 2024
rifont
approved these changes
Apr 23, 2024
| @@ -18,7 +19,7 @@ export class WSGateway implements OnGatewayConnection, OnGatewayDisconnect, IDes | |||
| constructor(private jwtService: JwtService, private subscriberOnlineService: SubscriberOnlineService) {} | |||
|
|
|||
| @WebSocketServer() | |||
| server: Server | null; | |||
| server: Server; | |||
|
|
||
| afterInit() { | ||
| if (!!process.env.SOCKET_IO_ADMIN_USERNAME && !!process.env.SOCKET_IO_ADMIN_PASSWORD_HASH) { | ||
| instrument(this.server, { |
There was a problem hiding this comment.
✏ suggestion: Could we add a URL link to the configuration options for Socket.io? I find it useful to have a URL to click on to easily find the other options in case of maintenance + debugging. Specifically, I would like to know what effect the mode has on the admin panel.
There was a problem hiding this comment.
Do you mean as a comment? If yes, done!
SokratisVidros
force-pushed
the
socket_io_admin
branch
from
c98be8a to
62bb67d
Compare
This simple dashboard should be able to increase our visibility on WS connection status.
SokratisVidros
force-pushed
the
socket_io_admin
branch
from
62bb67d to
fddc837
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
This simple dashboard should be able to increase our visibility on WS connection status.
https://socket.io/docs/v4/admin-ui/