ci: Use * instead of ['*'] #5428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
antonjoel82
commented
Apr 17, 2024
| ['test', 'local'].includes(process.env.NODE_ENV) || | ||
| isWidgetRoute(req.url) || | ||
| isBlueprintRoute(req.url) || | ||
| hasPermittedDeployPreviewOrigin(origin) |
There was a problem hiding this comment.
🗒 note (non-blocking): I felt this cleaned up the code to leverage the same pattern and reuse the origin that we know is working
Cliftonz
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Unfortunately, this is still not working. While the origin code change seems to have been right anyway (yay!), it's still failing between the OPTIONS and POST requests...
Here are the logs for me logging into dev successfully (via
dev.web.novu.co). You’ll notice that two requests have req.url: /v1/auth/login . However, when I search by that immediately after trying to login via the deploy-preview, I don’t see a log like that.I see these logs that indicate that we are now doing the matching correctly during the OPTIONS request, but something is still going wrong after. I believe it's not responding correctly since I don't see Access-Control-Allow-Origin: * . Looking through the code, the only difference is setting origin: '' vs pushing '' onto the origins array... so trying that!