Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use origin instead of host #5426

Merged
merged 2 commits into from
Apr 17, 2024
Merged

fix: Use origin instead of host #5426

merged 2 commits into from
Apr 17, 2024

Conversation

antonjoel82
Copy link
Contributor

@antonjoel82 antonjoel82 commented Apr 17, 2024 •
edited
Loading

What changed? Why was the change needed?

  • Use origin instead of host while determining CORS

Context

Taken from NewRelic

req.headers.host:dev.api.novu.co
...
req.headers.origin:https://dev.web.novu.co

@netlify Netlify
Copy link

netlify bot commented Apr 17, 2024 •
edited
Loading

✅ Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit c00c0e2
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/6620053322f4c60008ef58e9
😎 Deploy Preview https://deploy-preview-5426--dev-web-novu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Apr 17, 2024 •
edited
Loading

✅ Deploy Preview for novu-design ready!

Name Link
🔨 Latest commit c00c0e2
🔍 Latest deploy log https://app.netlify.com/sites/novu-design/deploys/662005331173490008e7a8c6
😎 Deploy Preview https://deploy-preview-5426--novu-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antonjoel82 antonjoel82 merged commit d672a4b into next Apr 17, 2024
28 checks passed
@antonjoel82 antonjoel82 deleted the preview-cors branch April 17, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scopsy scopsy scopsy approved these changes

@SokratisVidros SokratisVidros SokratisVidros approved these changes

@Cliftonz Cliftonz Awaiting requested review from Cliftonz

Assignees
No one assigned
Labels
@novu/api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonjoel82 @SokratisVidros @scopsy