Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Working on fixing integration store, updated settings and integration provider fields #5072

Closed
wants to merge 20 commits into from
Closed

fix: Working on fixing integration store, updated settings and integration provider fields #5072

wants to merge 20 commits into from

Conversation

AlexVCS
Copy link
Contributor

@AlexVCS AlexVCS commented Jan 11, 2024

What change does this PR introduce?

Working to update integration store to show integration provider per the Figma file.

Why was this change needed?

Working on issue #5061

Other information (Screenshots)

Right now it's not 100% complete. The copy button looks a little different than the Figma shows and it appears on load and not just onHover. The text also needs to turn to white on hover. I'm still working to figure out the best ways to do that, open to feedback.

Screenshot 2024-01-11 at 4 42 47 PM

Copy link

netlify bot commented Jan 17, 2024

👷 Deploy request for dev-web-novu pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 64a4b95

@AlexVCS AlexVCS marked this pull request as ready for review January 18, 2024 00:58
@AlexVCS
Copy link
Contributor Author

AlexVCS commented Jan 18, 2024

I'm close to having it just like the Figma. Still working to make the copy button only appear on hover and change color on hover. I hope I'll have it squared away tomorrow

@scopsy
Copy link
Contributor

scopsy commented Jan 24, 2024

@AlexVCS let me know when you are ready for a review! You can also utilize the Draft PR functionality.

@AlexVCS
Copy link
Contributor Author

AlexVCS commented Jan 25, 2024

@AlexVCS let me know when you are ready for a review! You can also utilize the Draft PR functionality.

Hey Dima, it's ready now :)

@github-actions github-actions bot added the stale Pull Request that needs to be reviewed label Apr 1, 2024
@AlexVCS AlexVCS requested a review from a team May 7, 2024 19:50
Copy link

netlify bot commented May 7, 2024

Deploy Preview for novu-design ready!

Name Link
🔨 Latest commit 64a4b95
🔍 Latest deploy log https://app.netlify.com/sites/novu-design/deploys/6646960b1bbdc6000860f220
😎 Deploy Preview https://deploy-preview-5072--novu-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AlexVCS AlexVCS closed this by deleting the head repository Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community @novu/web stale Pull Request that needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants