Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pkg): added integrationidentifier in setcredential method in nod… #4994

Conversation

Prashant-dot1
Copy link
Contributor

@Prashant-dot1 Prashant-dot1 commented Dec 17, 2023

What change does this PR introduce?

  • This PR adds a feature into the nodejs SDK -

    • While updating the credentials of a provider (e.g - slack) for a particular subscriber , we can now also pass the integrationIndentifier field which lets us choose for which integration, credentials can be updated.
  • Updated the sedCredentials method to also include integrationIdentifier as a new field.

  • Updated the README.md file for setCredentials

  • Now the setCredentials method can also be called using this way -

    `await novu.subscribers.setCredentials("subscriberId","slack",{
         webhookUrl: ["webhookUrl"]
      },"identifier_slack")`
    

Why was this change needed?

Closes #4874

@jainpawan21 jainpawan21 enabled auto-merge (squash) December 19, 2023 17:51
@jainpawan21 jainpawan21 merged commit ff5c93d into novuhq:next Dec 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NV-3199] feature: add integrationIdentifier field in node sdk
2 participants