Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(providers): Migrate from onesignal-node SDK to the official @onesignal/node-onesignal #4840

Merged
merged 17 commits into from
Nov 20, 2023

Conversation

Dhoni77
Copy link
Contributor

@Dhoni77 Dhoni77 commented Nov 13, 2023

What change does this PR introduce?

  • Remove onesignal-node sdk
  • Use @onesignal/node-onesignal sdk
  • Updated unit tests

Why was this change needed?

Closes #4635

Due to vulnerabilities and un-maintained SDK, we should move from using unofficial onesignal-node SDK.

Copy link
Contributor

@scopsy scopsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make sure that we are not providing a breaking change for old configuration users who used the apiKey and applicationId approach.

@scopsy
Copy link
Contributor

scopsy commented Nov 14, 2023

@Dhoni77 another approach we can take is using the rest API directly which works with API key and AppId like previously: https://documentation.onesignal.com/reference/create-notification we can use axios for the API call, wdyt?

@Dhoni77
Copy link
Contributor Author

Dhoni77 commented Nov 14, 2023

@Dhoni77 another approach we can take is using the rest API directly which works with API key and AppId like previously: https://documentation.onesignal.com/reference/create-notification we can use axios for the API call, wdyt?

Sure I'll try using the rest api

@Dhoni77 Dhoni77 marked this pull request as ready for review November 14, 2023 10:14
@Dhoni77 Dhoni77 requested a review from scopsy November 14, 2023 10:15
@scopsy scopsy merged commit 74d9320 into novuhq:next Nov 20, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NV-3053] Migrate from onesignal-node SDK to the official @onesignal/node-onesignal
2 participants