-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(providers): Migrate from onesignal-node SDK to the official @onesignal/node-onesignal #4840
Conversation
packages/application-generic/src/factories/push/handlers/one-signal.handler.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make sure that we are not providing a breaking change for old configuration users who used the apiKey and applicationId approach.
@Dhoni77 another approach we can take is using the rest API directly which works with API key and AppId like previously: https://documentation.onesignal.com/reference/create-notification we can use axios for the API call, wdyt? |
Sure I'll try using the rest api |
What change does this PR introduce?
@onesignal/node-onesignal
sdkWhy was this change needed?
Closes #4635
Due to vulnerabilities and un-maintained SDK, we should move from using unofficial onesignal-node SDK.