feat: add grafana on call as chat provider #4759
Conversation
github-actions
bot
added
@novu/api
@novu/web
@novu/dal
@novu/shared
providers
community
labels
mahendraHegde
force-pushed
the
feat/graphana-provider
branch
from
5d168f1 to
4ec338c
Compare
| @@ -0,0 +1,78 @@ | |||
| { | |||
| "name": "@novu/grafana-on-call", | |||
| "version": "0.16.3", | |||
There was a problem hiding this comment.
This version should be the same as the rest of the providers, v0.21.0
There was a problem hiding this comment.
okay, out of curiocity, whats the reason to keep all provider version same? also this is auto generated.
There was a problem hiding this comment.
I am not sure, that is a @LetItRock question
There was a problem hiding this comment.
upgraded to 0.21.0
| const { headers } = await this.axiosInstance.post(url.toString(), body); | ||
|
|
||
| return { | ||
| id: this.config.alertUid || options.content, |
There was a problem hiding this comment.
What does the options.content return?
There was a problem hiding this comment.
this is actually the message itself, there is no valid identifier that grafana returns in response(body/header), it it acceptable to generate a uuid and use it as it instead?
There was a problem hiding this comment.
For this use-case yes, we should not be using the actual message as the id here.
mahendraHegde
force-pushed
the
feat/graphana-provider
branch
3 times, most recently
from
4e6113c to
f66fb82
Compare
apps/web/public/static/images/providers/dark/square/grafana-on-call.svg
Outdated
Show resolved
Hide resolved
mahendraHegde
force-pushed
the
feat/graphana-provider
branch
from
f66fb82 to
a6bf5f7
Compare
What change does this PR introduce?
Why was this change needed?
closes #4682 and #4438
Other information (Screenshots)
Integration config
Workflow
Grafana dashboard