Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): Centralize the nodes in the middle of the screen #4727

Closed
wants to merge 2 commits into from

Conversation

mr-unmole
Copy link

What change does this PR introduce?

Element has been centered as required

Why was this change needed?

Closes #4256

@scopsy scopsy changed the title Fixes: #4256 fix(web): Centralize the nodes in the middle of the screen Nov 6, 2023
Copy link
Contributor

@scopsy scopsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anmol-matharu-100 Unfortunately when there are multiple nodes in the screen it still starts from the same position.

We need to make it a bit more dynamic, so that it centers the whole block of items like in the second image
CleanShot 2023-11-06 at 09 29 47@2x

Expected behaviour:
CleanShot 2023-11-06 at 09 30 29@2x

When having more nodes than bounding space in view, we should just attach to the top like previously.

@github-actions github-actions bot added the stale Pull Request that needs to be reviewed label Nov 20, 2023
@LetItRock
Copy link
Contributor

closing as not active

@LetItRock LetItRock closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community @novu/web stale Pull Request that needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NV-2732] Workflow adjust the initial workflow steps location
3 participants