feat: Added MessageBird SMS client #4687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the MessageBird SMS client to our project.
Cliftonz
suggested changes
Oct 28, 2023
| @@ -98,6 +98,7 @@ | |||
| "@novu/telnyx": "^0.21.0", | |||
| "@novu/termii": "^0.21.0", | |||
| "@novu/testing": "^0.21.0", | |||
| "@novu/messagebird": "^0.16.3", | |||
There was a problem hiding this comment.
version should be the same as the rest
providers/messagebird/package.json
Outdated
| @@ -0,0 +1,78 @@ | |||
| { | |||
| "name": "@novu/messagebird", | |||
| "version": "0.16.3", | |||
providers/messagebird/README.md
Outdated
|
|
||
| ## Usage | ||
|
|
||
| # MessageBird Node.js API Client |
There was a problem hiding this comment.
It looks like you just copy pasted the docs for the client, please look at some of the other providers and make this Novu centric.
Added messagebird version as 0.21.0, updated readme to novu specific
Added messagebird version as 0.21.0, updated readme to novu specific
|
hey @Cliftonz , Did the changes as you requested. |
|
Looks like the cspell pipeline failed, you will need to add these two words will need to be added to the cspell list. |
|
hey @Cliftonz , Added them to cspell |
Cliftonz
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
This commit adds the MessageBird SMS client to our project.
Why was this change needed?
Closes #4386
Other information (Screenshots)