Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.20.0 LTS node upgrade #4556

Merged
merged 44 commits into from
Dec 31, 2023
Merged
Show file tree
Hide file tree
Changes from 28 commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
4c1e121
chore: update to node 18 lts
raikasdev Aug 22, 2023
7b4442b
Merge branch 'next' into update-to-newer-node
Aug 23, 2023
0e0e134
Merge branch 'next' into update-to-newer-node
Aug 23, 2023
2c10da0
Merge branch 'next' into update-to-newer-node
Cliftonz Aug 25, 2023
f61bea8
chore: merge next branch
raikasdev Aug 29, 2023
4c4021a
Merge branch 'next' into update-to-newer-node
Cliftonz Aug 29, 2023
b993da7
Merge branch 'next' into update-to-newer-node
Cliftonz Aug 29, 2023
0829f32
Merge branch 'update-to-newer-node' of ssh://github.com/raikasdev/nov…
raikasdev Aug 29, 2023
0af6d84
fix: add words to .cspell.json
raikasdev Aug 29, 2023
ed94dfe
Merge branch 'next' into update-to-newer-node
Cliftonz Sep 6, 2023
875f17d
Merge branch 'next' into update-to-newer-node
Cliftonz Sep 11, 2023
b138ed5
Merge branch 'next' into update-to-newer-node
scopsy Sep 12, 2023
85ac425
Merge branch 'next' into update-to-newer-node
scopsy Sep 18, 2023
77aa005
Merge branch 'next' into pr/4014
scopsy Sep 28, 2023
da49c01
Merge branch 'next' into pr/4014
scopsy Sep 28, 2023
a1625e0
fix: replace tcp port
scopsy Sep 28, 2023
09c53c7
fix: update tcp on wait-on
scopsy Sep 28, 2023
6a70cf5
refactor: more restrictive node engine permission
scopsy Sep 28, 2023
892af64
fix: wait-on check
scopsy Sep 29, 2023
55d9265
chore: test cypress
scopsy Sep 29, 2023
bb9558e
Merge branch 'node-upgrade' into update-to-newer-node
scopsy Oct 17, 2023
f2bd79a
Merge pull request #4014 from raikasdev/update-to-newer-node
scopsy Oct 17, 2023
41edc46
Merge branch 'next' into node-upgrade
scopsy Oct 17, 2023
5a261f8
fix: localhost binding
scopsy Oct 17, 2023
86598e9
fix: localhost to 127.0.0.1
scopsy Oct 17, 2023
fa0fe3a
fix: localhost pointer
scopsy Oct 17, 2023
73bb044
Revert "fix: localhost to 127.0.0.1"
scopsy Oct 17, 2023
d5d797a
Revert "fix: localhost pointer"
scopsy Oct 17, 2023
f996437
fix: update localhost values
scopsy Oct 17, 2023
077eab9
fix: restore ipv 4 address
scopsy Oct 17, 2023
32db132
Update .cspell.json
scopsy Oct 17, 2023
f817bad
fix: node 20 update
scopsy Oct 17, 2023
e6352ac
Merge branch 'node-upgrade' of https://github.com/novuhq/novu into no…
scopsy Oct 17, 2023
b893e8d
chore: update docker images
scopsy Oct 17, 2023
df4c634
Merge branch 'next' into node-upgrade
scopsy Oct 19, 2023
16bb0a9
Merge branch 'next' into node-upgrade
scopsy Nov 5, 2023
05fa63d
Merge branch 'next' into node-upgrade
scopsy Nov 26, 2023
33f8158
Merge branch 'next' into node-upgrade
scopsy Dec 14, 2023
61d33c4
Merge branch 'next' into node-upgrade
scopsy Dec 18, 2023
aa62a06
Merge branch 'next' into node-upgrade
scopsy Dec 28, 2023
aeb6a08
fix: replace localhost
scopsy Dec 28, 2023
3802629
fix: test
scopsy Dec 28, 2023
c99ce54
Merge branch 'node-upgrade' of https://github.com/novuhq/novu into no…
scopsy Dec 28, 2023
1a358e4
Merge branch 'next' into node-upgrade
scopsy Dec 31, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,10 @@
"reactjs",
"nextjs",
"vanillajs",
"quckstart",
scopsy marked this conversation as resolved.
Show resolved Hide resolved
"errmsg",
"devcontainer",
"INITDB",
"springboot",
"errmsg",
"shelljs",
Expand Down
5 changes: 1 addition & 4 deletions .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# [Choice] Node.js version (use -bullseye variants on local arm64/Apple Silicon): 16, 14, 12, 16-bullseye, 14-bullseye, 12-bullseye, 16-buster, 14-buster, 12-buster
ARG VARIANT=16-bullseye
ARG VARIANT=18-bullseye
FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:0-${VARIANT}

# Install MongoDB command line tools if on buster and x86_64 (arm64 not supported)
Expand All @@ -23,6 +23,3 @@ RUN . /etc/os-release \

# [Optional] Uncomment if you want to install more global node modules
RUN su node -c "npm install -g [email protected]"



2 changes: 1 addition & 1 deletion .devcontainer/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ services:
# Update 'VARIANT' to pick an LTS version of Node.js: 16, 14, 12.
# Append -bullseye or -buster to pin to an OS version.
# Use -bullseye variants on local arm64/Apple Silicon.
VARIANT: 16-bullseye
VARIANT: 18-bullseye
volumes:
- ..:/workspace:cached

Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ body:
attributes:
label: node version
description: In case of self-hosting or local installation mention the node version. If using our cloud-managed solution, mention NA.
placeholder: 16.0.0
placeholder: 18.0.0
- type: textarea
id: additional-context
validations:
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/docker/build-api/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ runs:
docker tag novu-api ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:$IMAGE_TAG

docker run --network=host --name api -dit --env NODE_ENV=test ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:$IMAGE_TAG
docker run --network=host appropriate/curl --retry 10 --retry-delay 5 --retry-connrefused http://localhost:1337/v1/health-check | grep 'ok'
docker run --network=host appropriate/curl --retry 10 --retry-delay 5 --retry-connrefused http://127.0.0.1:1337/v1/health-check | grep 'ok'

echo "IMAGE=ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:$IMAGE_TAG" >> $GITHUB_OUTPUT

Expand Down
2 changes: 1 addition & 1 deletion .github/actions/docker/build-worker/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ runs:

echo "Run image"
docker run --network=host --name worker -dit --env NODE_ENV=test ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:$IMAGE_TAG
docker run --network=host appropriate/curl --retry 10 --retry-delay 5 --retry-connrefused http://localhost:1342/v1/health-check | grep 'ok'
docker run --network=host appropriate/curl --retry 10 --retry-delay 5 --retry-connrefused http://127.0.0.1:1342/v1/health-check | grep 'ok'

echo "IMAGE=ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:$IMAGE_TAG" >> $GITHUB_OUTPUT

Expand Down
2 changes: 1 addition & 1 deletion .github/actions/run-api/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,4 @@ runs:

- name: Wait on API
shell: bash
run: wait-on --timeout=180000 http://localhost:1336/v1/health-check
run: wait-on --timeout=180000 http://127.0.0.1:1336/v1/health-check
4 changes: 2 additions & 2 deletions .github/actions/run-backend/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ runs:
NODE_ENV: "test"
PORT: "1336"
TZ: "UTC"
GITHUB_OAUTH_REDIRECT: "http://localhost:1336/v1/auth/github/callback"
GITHUB_OAUTH_REDIRECT: "http://127.0.0.1:1336/v1/auth/github/callback"
LAUNCH_DARKLY_SDK_KEY: ${{ inputs.launch_darkly_sdk_key }}
run: cd apps/api && pnpm start:build &

Expand All @@ -41,4 +41,4 @@ runs:

- name: Wait on API and Worker
shell: bash
run: wait-on --timeout=180000 http://localhost:1336/v1/health-check http://localhost:1342/v1/health-check
run: wait-on --timeout=180000 http://127.0.0.1:1336/v1/health-check http://127.0.0.1:1342/v1/health-check
2 changes: 1 addition & 1 deletion .github/actions/run-worker/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ runs:

- name: Wait on worker
shell: bash
run: wait-on --timeout=180000 http://localhost:1342/v1/health-check
run: wait-on --timeout=180000 http://127.0.0.1:1342/v1/health-check
2 changes: 1 addition & 1 deletion .github/actions/setup-project/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ runs:
- uses: actions/setup-node@v3
name: ⚙️ Setup Node Version
with:
node-version: '16.15.1'
node-version: '18.17.1'
cache: 'pnpm'

- name: 💵 Start Redis
Expand Down
4 changes: 2 additions & 2 deletions .github/actions/start-localstack/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ runs:
do
sleep 1
[[ counter -eq $max_retry ]] && echo "Failed!" && exit 1
aws --endpoint-url=http://localhost:4566 s3 ls
aws --endpoint-url=http://127.0.0.1:4566 s3 ls
echo "Trying again. Try #$counter"
((counter++))
done
docker-compose -f docker-compose.localstack.yml logs --tail="all"
aws --endpoint-url=http://localhost:4566 --cli-connect-timeout 600 s3 mb s3://novu-test
aws --endpoint-url=http://127.0.0.1:4566 --cli-connect-timeout 600 s3 mb s3://novu-test
2 changes: 1 addition & 1 deletion .github/actions/validate-swagger/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ runs:
- name: Get swagger json as file
shell: bash
run: |
curl -o swagger.json http://localhost:1336/api-json
curl -o swagger.json http://127.0.0.1:1336/api-json

- uses: char0n/swagger-editor-validate@v1
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/community-label.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- name: Install Octokit
run: npm --prefix .github/workflows/scripts install @octokit/action

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dev-deploy-webhook.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
docker tag novu-webhook ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:$IMAGE_TAG

docker run --network=host --name webhook -dit --env NODE_ENV=test ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:$IMAGE_TAG
docker run --network=host appropriate/curl --retry 10 --retry-delay 5 --retry-connrefused http://localhost:1341/v1/health-check | grep 'ok'
docker run --network=host appropriate/curl --retry 10 --retry-delay 5 --retry-connrefused http://127.0.0.1:1341/v1/health-check | grep 'ok'

docker push ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:dev
docker push ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:$IMAGE_TAG
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dev-deploy-ws.yml
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ jobs:
echo $GH_PASSWORD | docker login ghcr.io -u $GH_ACTOR --password-stdin
docker build -t ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:$IMAGE_TAG --build-arg BULL_MQ_PRO_TOKEN=${BULL_MQ_PRO_NPM_TOKEN} -f apps/ws/Dockerfile .
docker run --network=host --name api -dit --env NODE_ENV=test ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:$IMAGE_TAG
docker run --network=host appropriate/curl --retry 10 --retry-delay 5 --retry-connrefused http://localhost:1340/v1/health-check | grep 'ok'
docker run --network=host appropriate/curl --retry 10 --retry-delay 5 --retry-connrefused http://127.0.0.1:1340/v1/health-check | grep 'ok'
docker tag ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:$IMAGE_TAG ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:dev
docker push ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:dev
docker push ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:$IMAGE_TAG
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/issue-label.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- name: Install Octokit
run: npm --prefix .github/workflows/scripts install @octokit/action

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/milestone-assign.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
- name: Install Octokit
run: npm --prefix .github/workflows/scripts install @octokit/action

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/prod-deploy-api.yml
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ jobs:
docker tag novu-api ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:$IMAGE_TAG

docker run --network=host --name api -dit --env NODE_ENV=test ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:$IMAGE_TAG
docker run --network=host appropriate/curl --retry 10 --retry-delay 5 --retry-connrefused http://localhost:1337/v1/health-check | grep 'ok'
docker run --network=host appropriate/curl --retry 10 --retry-delay 5 --retry-connrefused http://127.0.0.1:1337/v1/health-check | grep 'ok'

docker push ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:prod
docker push ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:latest
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/prod-deploy-webhook.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
docker tag novu-webhook ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:$IMAGE_TAG

docker run --network=host --name webhook -dit --env NODE_ENV=test ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:$IMAGE_TAG
docker run --network=host appropriate/curl --retry 10 --retry-delay 5 --retry-connrefused http://localhost:1341/v1/health-check | grep 'ok'
docker run --network=host appropriate/curl --retry 10 --retry-delay 5 --retry-connrefused http://127.0.0.1:1341/v1/health-check | grep 'ok'

docker push ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:prod
docker push ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:latest
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/prod-deploy-worker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:
docker tag novu-worker ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:$IMAGE_TAG

docker run --network=host --name worker -dit --env NODE_ENV=test ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:$IMAGE_TAG
docker run --network=host appropriate/curl --retry 10 --retry-delay 5 --retry-connrefused http://localhost:1342/v1/health-check | grep 'ok'
docker run --network=host appropriate/curl --retry 10 --retry-delay 5 --retry-connrefused http://127.0.0.1:1342/v1/health-check | grep 'ok'

docker push ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:prod
docker push ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:latest
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/prod-deploy-ws.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
echo $GH_PASSWORD | docker login ghcr.io -u $GH_ACTOR --password-stdin
docker build --build-arg BULL_MQ_PRO_TOKEN=${BULL_MQ_PRO_NPM_TOKEN} -t ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:$IMAGE_TAG -f apps/ws/Dockerfile .
docker run --network=host --name api -dit --env NODE_ENV=test ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:$IMAGE_TAG
docker run --network=host appropriate/curl --retry 10 --retry-delay 5 --retry-connrefused http://localhost:1340/v1/health-check | grep 'ok'
docker run --network=host appropriate/curl --retry 10 --retry-delay 5 --retry-connrefused http://127.0.0.1:1340/v1/health-check | grep 'ok'
docker tag ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:$IMAGE_TAG ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:prod
docker tag ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:$IMAGE_TAG ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:latest
docker push ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:prod
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/reusable-web-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,9 @@ jobs:
- name: Start Client
working-directory: apps/web
env:
REACT_APP_API_URL: http://localhost:1336
REACT_APP_WS_URL: http://localhost:1340
REACT_APP_WEBHOOK_URL: http://localhost:1341
REACT_APP_API_URL: http://127.0.0.1:1336
REACT_APP_WS_URL: http://127.0.0.1:1340
REACT_APP_WEBHOOK_URL: http://127.0.0.1:1341
REACT_APP_LAUNCH_DARKLY_CLIENT_SIDE_ID: ${{ secrets.TEST_LAUNCH_DARKLY_CLIENT_SIDE_ID }}
run: pnpm start:static:build &

Expand All @@ -85,7 +85,7 @@ jobs:
cd apps/ws && pnpm start:test &

- name: Wait on Services
run: wait-on --timeout=180000 http://localhost:1340/v1/health-check http://localhost:4200
run: wait-on --timeout=180000 http://127.0.0.1:1340/v1/health-check http://0.0.0.0:4200/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for using 0.0.0.0 here? This usually has the effect of assigning a non-routable IP. In this case however, it seems we're using it for the default route.

If there is a reason, it would be good to add a comment to describe why, as this deviates from using localhost in both places previously.

.github/workflows/reusable-widget-e2e.yml is also using 0.0.0.0 in a couple of places for the same health check.


# run cypress install only when cache was not hit
- name: Cypress install
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/reusable-widget-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ jobs:
cd apps/ws && pnpm start:prod &

- name: Wait on Widget and WS Services
run: wait-on --timeout=180000 http://localhost:1340/v1/health-check http://localhost:3500
run: wait-on --timeout=180000 http://127.0.0.1:1340/v1/health-check http://0.0.0.0:3500/

- name: Cypress install
if: steps.setup-project.outputs.cypress_cache_hit != 'true'
Expand All @@ -102,7 +102,7 @@ jobs:
CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_WIDGET_KEY }}
with:
working-directory: apps/widget
wait-on: http://localhost:3500
wait-on: http://0.0.0.0:3500/
browser: chrome
install: false
record: true
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/tag-images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
run: echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p
- uses: actions/setup-node@v3
with:
node-version: '16.15.1'
node-version: '18.17.1'

- name: Login to docker
env:
Expand Down Expand Up @@ -125,4 +125,3 @@ jobs:
docker pull ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:prod
docker tag ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:prod ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:$DOCKER_VERSION
docker push ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:$DOCKER_VERSION

2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.15.1
18.17.1
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ You can open a new issue with this [issue form](https://github.com/novuhq/novu/i

### Requirements

- Node.js version v16.15.1
- Node.js version v18.17.1 (LTS)
- MongoDB
- Redis. To install Redis on your O.S, please follow the below guides
- [To install Redis on Windows](https://redis.io/docs/getting-started/installation/install-redis-on-windows/)
Expand Down
2 changes: 1 addition & 1 deletion apps/api/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM nikolaik/python-nodejs:python3.10-nodejs16-alpine as dev_base
FROM nikolaik/python-nodejs:python3.10-nodejs18-alpine as dev_base

ARG BULL_MQ_PRO_TOKEN
ENV BULL_MQ_PRO_NPM_TOKEN=$BULL_MQ_PRO_TOKEN
Expand Down
20 changes: 10 additions & 10 deletions apps/api/src/.env.test
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
GOOGLE_OAUTH_CLIENT_ID=11
GOOGLE_OAUTH_CLIENT_SECRET=11
GOOGLE_OAUTH_REDIRECT=http://localhost:3000/v1/auth/google/callback
GOOGLE_OAUTH_REDIRECT=http://127.0.0.1:3000/v1/auth/google/callback
STORE_ENCRYPTION_KEY="<ENCRYPTION_KEY_MUST_BE_32_LONG>"
BLUEPRINT_CREATOR=645b648b36dd6d25f8650d37

CLIENT_SUCCESS_AUTH_REDIRECT=http://localhost:4200/auth/login
CLIENT_SUCCESS_AUTH_REDIRECT=http://127.0.0.1:4200/auth/login

MONGO_URL=mongodb://localhost:27017/novu-test
MONGO_URL=mongodb://127.0.0.1:27017/novu-test
REDIS_PORT=6379
REDIS_HOST=localhost
REDIS_PREFIX=
Expand All @@ -21,7 +21,7 @@ REDIS_CACHE_CONNECTION_TIMEOUT=
REDIS_CACHE_KEEP_ALIVE=
REDIS_CACHE_FAMILY=
REDIS_CACHE_KEY_PREFIX=
REDIS_CACHE_ENABLE_AUTOPIPELINING=false
REDIS_CACHE_ENABLE_AUTOPIPELINING=false

IS_IN_MEMORY_CLUSTER_MODE_ENABLED=false
ELASTICACHE_CLUSTER_SERVICE_HOST=
Expand All @@ -36,8 +36,8 @@ REDIS_CLUSTER_KEEP_ALIVE=
REDIS_CLUSTER_FAMILY=
REDIS_CLUSTER_KEY_PREFIX=

SYNC_PATH=http://localhost:3001
API_ROOT_URL=http://localhost:3000
SYNC_PATH=http://127.0.0.1:3001
API_ROOT_URL=http://127.0.0.1:3000
DISABLE_USER_REGISTRATION=false
PORT=1337
JWT_SECRET=ASD#asda23DFEFSFHG%fg
Expand All @@ -46,14 +46,14 @@ SENDGRID_API_KEY=SG.123123
S3_ACCESS_KEY=
S3_SECRET=
REDIS_ARENA_PORT=4568
FRONT_BASE_URL=http://localhost:4200
FRONT_BASE_URL=http://127.0.0.1:4200
[email protected]
BACK_OFFICE_URL=http://localhost:5200
BACK_OFFICE_URL=http://127.0.0.1:5200
INTERCOM_API_KEY=
GLOBAL_CONTEXT_PATH=
API_CONTEXT_PATH=

S3_LOCAL_STACK=http://localhost:4566
S3_LOCAL_STACK=http://127.0.0.1:4566
S3_BUCKET_NAME=novu-test
S3_REGION=us-east-1
GCS_BUCKET_NAME=novu-test
Expand All @@ -70,7 +70,7 @@ MAIL_SERVER_DOMAIN=

VERCEL_CLIENT_ID=
VERCEL_CLIENT_SECRET=
VERCEL_REDIRECT_URI=http://localhost:4200/auth/login
VERCEL_REDIRECT_URI=http://127.0.0.1:4200/auth/login
VERCEL_BASE_URL=https://api.vercel.com

FF_IS_TOPIC_NOTIFICATION_ENABLED=true
Expand Down
10 changes: 5 additions & 5 deletions apps/api/src/.example.env
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
NODE_ENV=local
PORT=3000
API_ROOT_URL=http://localhost:3000
FRONT_BASE_URL=http://localhost:4200
API_ROOT_URL=http://127.0.0.1:3000
FRONT_BASE_URL=http://127.0.0.1:4200
STORE_ENCRYPTION_KEY="<ENCRYPTION_KEY_MUST_BE_32_LONG>"
DISABLE_USER_REGISTRATION=false

MONGO_URL=mongodb://localhost:27017/novu-db
MONGO_URL=mongodb://127.0.0.1:27017/novu-db
MONGO_MAX_POOL_SIZE=500
REDIS_PORT=6379
REDIS_PREFIX=
Expand Down Expand Up @@ -37,7 +37,7 @@ REDIS_CLUSTER_KEY_PREFIX=

JWT_SECRET=%LOCAL_TEST&@Ub4&9s

S3_LOCAL_STACK=http://localhost:4566
S3_LOCAL_STACK=http://127.0.0.1:4566
S3_BUCKET_NAME=novu-local
S3_REGION=us-east-1
AWS_ACCESS_KEY_ID=test
Expand All @@ -51,7 +51,7 @@ GLOBAL_CONTEXT_PATH=
API_CONTEXT_PATH=
VERCEL_CLIENT_ID=
VERCEL_CLIENT_SECRET=
VERCEL_REDIRECT_URI=http://localhost:4200/auth/login
VERCEL_REDIRECT_URI=http://127.0.0.1:4200/auth/login
VERCEL_BASE_URL=https://api.vercel.com

FF_IS_TOPIC_NOTIFICATION_ENABLED=true
Expand Down
2 changes: 1 addition & 1 deletion apps/api/src/app/events/e2e/process-subscriber.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ async function updateSubscriberPreference(
subscriberToken: string,
templateId: string
) {
return await axios.patch(`http://localhost:${process.env.PORT}/v1/widgets/preferences/${templateId}`, data, {
return await axios.patch(`http://127.0.0.1:${process.env.PORT}/v1/widgets/preferences/${templateId}`, data, {
headers: {
Authorization: `Bearer ${subscriberToken}`,
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ describe('Get Notifications feed - /:subscriberId/notifications/feed (GET)', fun

async function getNotificationsFeed(subscriberId: string, apiKey: string, query = {}) {
const response = await axios.get(
`http://localhost:${process.env.PORT}/v1/subscribers/${subscriberId}/notifications/feed`,
`http://127.0.0.1:${process.env.PORT}/v1/subscribers/${subscriberId}/notifications/feed`,
{
params: {
...query,
Expand Down
2 changes: 1 addition & 1 deletion apps/api/src/app/subscribers/e2e/get-unseen-count.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ describe('Get Unseen Count - /:subscriberId/notifications/unseen (GET)', functio

async function getUnSeenCount(subscriberId: string, apiKey: string, query = {}) {
const response = await axios.get(
`http://localhost:${process.env.PORT}/v1/subscribers/${subscriberId}/notifications/unseen`,
`http://127.0.0.1:${process.env.PORT}/v1/subscribers/${subscriberId}/notifications/unseen`,
{
params: {
...query,
Expand Down
Loading
Loading