-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-feat(provider): guilded provider added #4494
re-feat(provider): guilded provider added #4494
Conversation
Hi @Cliftonz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dont forget your unit tests
Hi I have made the requested changes |
I would recommend looking at other providers or posting in the issue that you need help from other commutiy members. |
@Kanav-Arora looks like there are a few conflicts that need resolved. |
…hat-provider' into nv-2962-guilded-chat-provider
@Kanav-Arora Please fix the conflicts as I think we are getting close to merging this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the conflicts and we are ready to go
* feat: add actor to system variables * test: add test for actor variables * chore: update lock file --------- Co-authored-by: Dima Grossman <[email protected]>
removed the duplicate exports
changed the text Sign out to Log out
@Cliftonz Done |
@Kanav-Arora Did you purposely delete the repository? |
What change does this PR introduce?
Added Guilded chat provider as requested in #4382
Why was this change needed?
Closes #4382
Other information (Screenshots)