Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-feat(provider): guilded provider added #4494

Closed
wants to merge 24 commits into from
Closed

re-feat(provider): guilded provider added #4494

wants to merge 24 commits into from

Conversation

Kanav-Arora
Copy link

What change does this PR introduce?

Added Guilded chat provider as requested in #4382

Why was this change needed?

Closes #4382

Other information (Screenshots)

Screenshot 2023-10-11 at 10 49 10 PM Screenshot 2023-10-11 at 10 49 24 PM

@Kanav-Arora
Copy link
Author

Hi @Cliftonz
Please review this

Copy link
Contributor

@Cliftonz Cliftonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont forget your unit tests

@Kanav-Arora Kanav-Arora requested a review from Cliftonz October 12, 2023 15:48
@Kanav-Arora
Copy link
Author

Hi I have made the requested changes
Just to confirm is provider.spec.ts the unit test file. Please help me with it

@Cliftonz
Copy link
Contributor

Hi I have made the requested changes Just to confirm is provider.spec.ts the unit test file. Please help me with it

I would recommend looking at other providers or posting in the issue that you need help from other commutiy members.

@Cliftonz
Copy link
Contributor

@Kanav-Arora looks like there are a few conflicts that need resolved.

…hat-provider' into nv-2962-guilded-chat-provider
@Cliftonz
Copy link
Contributor

@Kanav-Arora Please fix the conflicts as I think we are getting close to merging this

Copy link
Contributor

@Cliftonz Cliftonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the conflicts and we are ready to go

@Kanav-Arora
Copy link
Author

@Cliftonz Done
Please merge

@github-actions github-actions bot added the stale Pull Request that needs to be reviewed label Nov 6, 2023
@Kanav-Arora Kanav-Arora closed this by deleting the head repository Nov 22, 2023
@Cliftonz
Copy link
Contributor

@Kanav-Arora Did you purposely delete the repository?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NV-2962] 🚀 Feature: Add Guilded Chat Provider
7 participants