Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(provider): [NV-2961] Add Google Chat Chat Provider #4381 #4453

Closed
wants to merge 0 commits into from
Closed

feat(provider): [NV-2961] Add Google Chat Chat Provider #4381 #4453

wants to merge 0 commits into from

Conversation

Sushmitha-93
Copy link

What change does this PR introduce?

Adds the Google Chat Provider.

Referred the following Google chat webhook documentation
Google Chat Webhook

Why was this change needed?

Closes #4381

Other information (Screenshots)

Integration-stores

Google chat workflow

build-successful

Cliftonz
Cliftonz suggested changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@Cliftonz Cliftonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change looks great otherwise! Good work!

providers/google-chat/README.md Outdated Show resolved Hide resolved
@Sushmitha-93 Sushmitha-93 requested a review from Cliftonz October 7, 2023 00:06
@davidsoderberg
Copy link
Contributor

Could you please provide a screenshot of how it looks in multi integration list set line 34 to true in useFeatureFlags file?

@Sushmitha-93
Copy link
Author

Could you please provide a screenshot of how it looks in multi integration list set line 34 to true in useFeatureFlags file?

Thanks for the suggestion @davidsoderberg. I will check and let you know by tomorrow. I'm currently focusing on my midterm exams.

@Sushmitha-93 Sushmitha-93 mentioned this pull request Oct 12, 2023
Closed
2 tasks
@Sushmitha-93
Copy link
Author

Could you please provide a screenshot of how it looks in multi integration list set line 34 to true in useFeatureFlags file?

Hi @davidsoderberg , this is how it was looking after I set line 34 to true in useFeatureFlags file.

Integration-store-with-useFeatureFlag-line34-true

I created a new PR #4381 and closed this one because I ended up starting with a new fork.

@Sushmitha-93 Sushmitha-93 mentioned this pull request Oct 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cliftonz Cliftonz Cliftonz approved these changes

@davidsoderberg davidsoderberg Awaiting requested review from davidsoderberg

Assignees
No one assigned
Labels
community @novu/shared @novu/web providers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NV-2961] 🚀 Feature: Add Google Chat Chat Provider
3 participants
@Sushmitha-93 @davidsoderberg @Cliftonz