NV-3934 - 🚀 Feature: Custom backendUrl in invite-member.usecase and resend-invite.usecase #4432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: AsiwajuDev <[email protected]>
|
@jainpawan21 @davidsoderberg this PR is ready for review |
|
@gitstart I will close this PR because someone else is working and assigned to the issue. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
This fix makes it possible Custom backendUrl in invite-member.usecase and resend-invite.usecase is added
Description
It would be great if when instantiating the Novu instance in invite-member.usecase.ts, resend-invite.usecase.ts, accept-invite.usecase.ts and password-reset-request.usecase.ts we could also pass a custom config object in case we want to inject our own backendUrl for example.
Why was this change needed?
closes #3934
Other information
This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.