fix: [NV-2841] Fixed issue of channel icons in light theme due to duplicate id in SVG #4358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Gaurav0493 there are some merge conflicts, could you please take a look at those? |
|
hey @Gaurav0493 👋 could you please give me the rights to push the changes to your fork? we would love to merge this PR 🙏 |
Hey @LetItRock I have sent invite to you for my fork. |
github-actions
bot
added
@novu/design-system
and removed
stale
thank you! 🙌 |
|
@Gaurav0493 thank you! 🤝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
This PR fixes the issue with channel icon color in light theme in the workflows.
This issue was due to duplicate id of linearGradient in SVGs of channel images.
When a channel is added in the workflow the duplicate id of the linearGradient gets added in the DOM due to which the color of the image defaults to white and i.e. the image is not visible in the white theme.
To fix this issue, I have used timestamp as a unique Id for these linearGradient. This will allow having multiple channel icons in the DOM.
Why was this change needed?
The changes fix the issue with channel icons in the light theme.
For example: When I add an email channel into the workflow ( in light theme) and then hover on the email channel from the actions menu to add the email channel again into the workflow the email channel disappears.
With this PR the above issue is fixed.
Closes #4260
Fix Screenshots
Light Mode
Dark Mode
===============================================================
This PR also fixes the issue with the color of filter icon on the Configure page for the channel in light theme.
Before fix
After fix