Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nv 2715 create the editor sidebar #4352

Merged
merged 11 commits into from
Oct 3, 2023

Conversation

ainouzgali
Copy link
Contributor

What change does this PR introduce?

Why was this change needed?

Other information (Screenshots)

@linear
Copy link

linear bot commented Oct 3, 2023

NV-2715 🔀 Create the Editor Sidebar

What?

Create the Editor Sidebar to be a reusable component. Update its UI according to the designs.

Why? (Context)

We would like to reuse the same Editor Sidebar for all the channels Editors and Variant Editors.

The only difference between Editor and Variant Editor is that it has an additional variant line under the name.

Definition of Done

  • the header
    • provider icon with a small channel icon at the right bottom corner
    • has the editable name field
    • has the ability to inject the custom component under the name (for variant)
  • the header actions
    • delete (before it was at the bottom)
    • conditions button (aka filters, do not implement it just show the filters modal)
    • close button

Screenshot 2023-08-30 at 09.25.09.png

Screenshot 2023-08-30 at 09.40.25.png

In-App condition - Tenants (Figma)

@ainouzgali ainouzgali marked this pull request as draft October 3, 2023 11:03
@ainouzgali ainouzgali marked this pull request as ready for review October 3, 2023 12:03
@ainouzgali ainouzgali merged commit ec498be into variants-condition Oct 3, 2023
14 of 16 checks passed
@ainouzgali ainouzgali deleted the nv-2715-create-the-editor-sidebar branch October 3, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants