-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nv 2715 create the editor sidebar #4352
Merged
ainouzgali
merged 11 commits into
variants-condition
from
nv-2715-create-the-editor-sidebar
Oct 3, 2023
Merged
Nv 2715 create the editor sidebar #4352
ainouzgali
merged 11 commits into
variants-condition
from
nv-2715-create-the-editor-sidebar
Oct 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-to-conditions-sidebar-in-the-editor' into nv-2715-create-the-editor-sidebar
…flow-endpoint' into nv-2715-create-the-editor-sidebar
…-create-the-editor-sidebar
NV-2715 🔀 Create the Editor Sidebar
What?Create the Editor Sidebar to be a reusable component. Update its UI according to the designs. Why? (Context)We would like to reuse the same Editor Sidebar for all the channels Editors and Variant Editors. The only difference between Editor and Variant Editor is that it has an additional variant line under the name. Definition of Done
Screenshot 2023-08-30 at 09.25.09.png |
…r' into nv-2715-create-the-editor-sidebar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Why was this change needed?
Other information (Screenshots)