fix: Fixed senders name in email while using resend email provider #4329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BiswaViraj
requested changes
Oct 3, 2023
| @@ -6,10 +6,11 @@ export class ResendHandler extends BaseHandler { | |||
| constructor() { | |||
| super('resend', ChannelTypeEnum.EMAIL); | |||
| } | |||
| buildProvider(credentials: ICredentials, from?: string) { | |||
| const config: { apiKey: string; from: string } = { | |||
| buildProvider(credentials: ICredentials, from?: string, senderName?: string) { | |||
There was a problem hiding this comment.
credentials: ICredentials already includes the senderName.
So we don't need to pass senderName as an extra param. Also in the current implementation. In the mail.factory.ts file, only 2 params are being passed for all the providers.
|
hi @mahimavarma! 👋 thanks for the contribution 🤝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
This PR will fix the name not being displayed in the email when the user is using Resend as an email provider.
Why was this change needed?
The change was to add the senderName before the from email address
Fixes:#3957
Other information (Screenshots)