fix(api): malformed filters in messages throw errors #4308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-fernandez
commented
Oct 2, 2023
| variables.push(...filterVariables); | ||
| const filters = Array.isArray(message.filters) ? message.filters : []; | ||
| const filteredVariables = filters.flatMap((filter) => { | ||
| const filteredChildren = filter.children?.filter((item) => item.on === FilterPartTypeEnum.PAYLOAD) || []; |
There was a problem hiding this comment.
This covers the Sentry error captured.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Fixes errors thrown by malformed filters in messages.
Why was this change needed?
To fix this:
https://novu-r9.sentry.io/issues/4518246046/?alert_rule_id=10492815&alert_timestamp=1696232113867&alert_type=email&environment=production¬ification_uuid=1f7176c6-ff05-4643-9a24-8b06a20c32e5&project=6248811&referrer=alert_email
Other information (Screenshots)