Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed react flow link #4302

Merged
merged 11 commits into from
Oct 4, 2023
Merged

Conversation

govardhanshah456
Copy link
Contributor

What change does this PR introduce?

Made the React Flow Link More foundable.

Why was this change needed?

closes #4266

Other information (Screenshots)

image

@scopsy
Copy link
Contributor

scopsy commented Oct 2, 2023

@govardhanshah456 could you please keep the original color of the link and just move the position to be centered as you did but with 30px top margin?

@govardhanshah456
Copy link
Contributor Author

govardhanshah456 commented Oct 2, 2023

I was going to keep original color only but then it is barely visible in dark mode so I changed it to deeppink:(image for refn)
image

when keeping hover one can notice but only when hover event occurs(image refn)
image

Also Margin top Won't work as position of parent div is absolute. we have to make current div position relative and apply top and right to make it centered, it is done though. I have pushed the required changes with color being reverted to original with hover present. If you feel like color needs to change please let me know.

Thanks.

@scopsy
Copy link
Contributor

scopsy commented Oct 2, 2023

I see, could you please just move it to the center with the old color? And just moving it down by 30px?

@govardhanshah456
Copy link
Contributor Author

I see, could you please just move it to the center with the old color? And just moving it down by 30px?

You can refer the latest commit, I have made that changes on it only

@scopsy
Copy link
Contributor

scopsy commented Oct 2, 2023

@govardhanshah456 mind sharing a photo of how it looks after the changes?

@govardhanshah456
Copy link
Contributor Author

@govardhanshah456 mind sharing a photo of how it looks after the changes?

image

@govardhanshah456
Copy link
Contributor Author

govardhanshah456 commented Oct 3, 2023

@scopsy & @LetItRock any changes required? I guess mostly we would like to change text color in dark mode.

In light mode, it looks like this:
image

In dark mode, it looks like this:
image

Copy link
Contributor

@scopsy scopsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small adjustment here

@scopsy
Copy link
Contributor

scopsy commented Oct 3, 2023

@govardhanshah456 please comment on the original issue so I can assign you

@govardhanshah456
Copy link
Contributor Author

@govardhanshah456 please comment on the original issue so I can assign you

yes, did that, and commited the suggestions provided

@govardhanshah456
Copy link
Contributor Author

@scopsy Hey, can you assign this to me? i have commented on the issue as well for the same.

Thanks

@scopsy scopsy merged commit a9d2d2a into novuhq:next Oct 4, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: [Quick start guide] Getting started page : React flow button UI fixing.
2 participants