Fix the kebab-case for css properties warning #4301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scopsy
reviewed
Oct 2, 2023
|
if everything is okay can you merge my pr @davidsoderberg |
|
Hi @sagnik3788, I think it should be |
|
Yes, you are correct it should be WebkitTextFillColor due to the camelCase property naming convention . i correct this |
ainouzgali
reviewed
Oct 15, 2023
There was a problem hiding this comment.
@sagnik3788 please run the prettier and I'll approve this. Thanks!
| @@ -66,7 +66,7 @@ export const getSubtleStyles = (theme) => { | |||
| backgroundColor: dark ? theme.white : 'transparent', | |||
| backgroundClip: 'none !important', | |||
| color: 'transparent', | |||
| '-webkit-text-fill-color': 'initial !important', | |||
| WebkitTextFillColor: 'initial !important', | |||
There was a problem hiding this comment.
This line should have the same indentation as the others.
LetItRock
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
solve the kebab-case for css properties warning
Why was this change needed?
solve issue #4294 @LetItRock
Other information (Screenshots)