Add WidgetShell Component #4290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description This pull request introduces a new component, WidgetShell, which acts as a wrapper for child components based on whether the application is running in an iframe or not. Changes Made Added a new component called WidgetShell to the codebase. Integrated WidgetShell into the existing code structure to conditionally render either TransparentShell or MockPreviewShell. Implemented conditional rendering logic based on whether the component is in an iframe. Added styles for TransparentShell, MockPreviewShell, and ShellWrapper. Added Features/Enhancements Introduced WidgetShell to manage the rendering behavior of child components. Applied conditional rendering to adapt to different environments (iframe vs. non-iframe). Fixed Issues None Testing The changes were thoroughly tested in the following ways: Reviewed for potential layout issues in different scenarios (iframe vs. non-iframe). Verified that the component's behavior aligns with expected outcomes. Known Issues/Considerations None
|
@HarshMN2345 please submit a reproducible issue describing what is that you are trying to solve before submitting a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a new component, WidgetShell, which acts as a wrapper for child components based on whether the application is running in an iframe or not.
Changes Made
Added a new component called WidgetShell to the codebase. Integrated WidgetShell into the existing code structure to conditionally render either TransparentShell or MockPreviewShell. Implemented conditional rendering logic based on whether the component is in an iframe. Added styles for TransparentShell, MockPreviewShell, and ShellWrapper. Added Features/Enhancements
Introduced WidgetShell to manage the rendering behavior of child components. Applied conditional rendering to adapt to different environments (iframe vs. non-iframe).
Fixed Issues-None
Testing:
The changes were thoroughly tested in the following ways:
Reviewed for potential layout issues in different scenarios (iframe vs. non-iframe). Verified that the component's behavior aligns with expected outcomes.
Known Issues/Considerations-None