-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the color to toggle in light and dark mode in workflows #4270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aniketsahu28 thank you for contributing!!
Could you please add screenshots of the result? :)
@@ -13,7 +13,7 @@ export function ChatFilled(props: React.ComponentPropsWithoutRef<'svg'>) { | |||
{...props} | |||
> | |||
<path | |||
fill="url(#paint0_linear_528_4335)" | |||
fill={theme.colorScheme === 'light' ? colors.B60 : 'white'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aniketsahu28 you do not have the theme or the colors import here. Am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will make the changes and upload screenshot in a while
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will you please check is it fine ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aniketsahu28 are you able to run this repo locally ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aniketsahu28 are you able to run this repo locally ?
I tried 3+ times, but I am not able to run it locally 🥲 @Aniketsahu28 @rjangid9080 @ainouzgali
@Aniketsahu28 this issue is not assigned to you, please ask to be assigned before submitting a PR 🙏 In case that the assigned on the issue contributor won't be able to do it and you will be assigned, feel free to reopen this PR. |
What change does this PR introduce?
This PR fixes channels icon over provider image to appear on light theme as well. It toggles its color to white in dark theme and B60 in light mode.
Why was this change needed?
The change was to toggle color with respect to the theme. Show white in dark mode and B60 in light mode.
Fixes #4260
Working screenshots