Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the color to toggle in light and dark mode in workflows #4270

Closed
wants to merge 2 commits into from

Conversation

Aniketsahu28
Copy link

@Aniketsahu28 Aniketsahu28 commented Oct 1, 2023

What change does this PR introduce?

This PR fixes channels icon over provider image to appear on light theme as well. It toggles its color to white in dark theme and B60 in light mode.

Why was this change needed?

The change was to toggle color with respect to the theme. Show white in dark mode and B60 in light mode.
Fixes #4260

Working screenshots
image

Copy link
Contributor

@ainouzgali ainouzgali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aniketsahu28 thank you for contributing!!
Could you please add screenshots of the result? :)

@@ -13,7 +13,7 @@ export function ChatFilled(props: React.ComponentPropsWithoutRef<'svg'>) {
{...props}
>
<path
fill="url(#paint0_linear_528_4335)"
fill={theme.colorScheme === 'light' ? colors.B60 : 'white'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aniketsahu28 you do not have the theme or the colors import here. Am I missing something?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make the changes and upload screenshot in a while

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you please check is it fine ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aniketsahu28 are you able to run this repo locally ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aniketsahu28 are you able to run this repo locally ?

I tried 3+ times, but I am not able to run it locally 🥲 @Aniketsahu28 @rjangid9080 @ainouzgali

Screenshot 2023-10-01 153937

@scopsy
Copy link
Contributor

scopsy commented Oct 2, 2023

@Aniketsahu28 this issue is not assigned to you, please ask to be assigned before submitting a PR 🙏 In case that the assigned on the issue contributor won't be able to do it and you will be assigned, feel free to reopen this PR.

@scopsy scopsy closed this Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NV-2841] Workflow Editor - channels icons are white in light theme
5 participants