Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace deprecated command with environment file #4208

Merged
merged 1 commit into from
Sep 28, 2023
Merged

chore: Replace deprecated command with environment file #4208

merged 1 commit into from
Sep 28, 2023

Conversation

jongwooo
Copy link
Contributor

What change does this PR introduce?

Update workflows to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow files that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

echo "::set-output name=IMAGE::ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:$IMAGE_TAG"

TO-BE

echo "IMAGE=ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:$IMAGE_TAG" >> $GITHUB_OUTPUT

Why was this change needed?

Closes #4207

Other information (Screenshots)

None

Copy link
Contributor

@p-fernandez p-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟 Thank you for your contribution.

A future improvement is to be able to reuse some of these variables generated inside of the YML files. But this is a great start and keeps us up to date with the GitHub actions changes.

@p-fernandez p-fernandez merged commit 19bf4f1 into novuhq:next Sep 28, 2023
20 checks passed
@jongwooo jongwooo deleted the chore/replace-deprecated-command-with-environment-file branch September 28, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NV-2919] Replace deprecated set-output command with environment file
2 participants