Make the Agents Metrics Accurate Again #4060
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-fernandez
reviewed
Aug 31, 2023
| const delayedCount = await queueService.bullMqService.queue.getDelayedCount(); | ||
| const activeCount = await queueService.bullMqService.queue.getActiveCount(); | ||
|
|
||
| if (process.env.NOVU_MANAGED_SERVICE === 'true' && process.env.NEW_RELIC_LICENSE_KEY) { |
There was a problem hiding this comment.
Should we move the condition to this service construction and avoid to instantiate anything for our self hosted users?
There was a problem hiding this comment.
I am not sure, you will need to let me know what is the best way to do this.
My thought is that for OS it will output to the cli so if they wanted to they can scrape this data for themselfs.
correct, metric queue test
p-fernandez
reviewed
Aug 31, 2023
apps/worker/src/app/workflow/services/metric-queue-active.service.ts
Outdated
Show resolved
Hide resolved
…ice.ts Co-authored-by: Pablo Fernández <[email protected]>
|
Moving to this PR: #4099 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
This pr corrects the times and granularity for metrics with bullmq.
Why was this change needed?
This pr will allow use to accurately autoscale our workers by sending the historical job processing data to a 3rd party New relic.