-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement rename organization #2634
Changes from 2 commits
af388db
b9370b6
b3a8998
60eb79a
dbcccb1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import { OrganizationRepository } from '@novu/dal'; | ||
import { UserSession } from '@novu/testing'; | ||
import { expect } from 'chai'; | ||
|
||
describe('Update Organization - /organizations (PUT)', function () { | ||
let session: UserSession; | ||
const organizationRepository = new OrganizationRepository(); | ||
|
||
beforeEach(async () => { | ||
session = new UserSession(); | ||
await session.initialize(); | ||
}); | ||
|
||
it('should update the organization name', async function () { | ||
const payload = { | ||
name: 'Liberty Powers', | ||
}; | ||
|
||
await session.testAgent.put('/v1/organizations').send(payload); | ||
|
||
const organization = await organizationRepository.findById(session.organization._id); | ||
|
||
expect(organization.name).to.equal(payload.name); | ||
}); | ||
}); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
import { IsDefined, MaxLength } from 'class-validator'; | ||
import { AuthenticatedCommand } from '../../../shared/commands/authenticated.command'; | ||
|
||
export class UpdateOrganizationCommand extends AuthenticatedCommand { | ||
@IsDefined() | ||
public readonly id: string; | ||
|
||
@MaxLength(50) | ||
name: string; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Abobos due you think we should add here some maxLen for the organization name? Would use something permissive here, but maybe providing some limit will be a good idea to not break UI and etc... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you throw more perspective?.. How would this break the UI if we don't limit it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For example everywhere we show the organization name it can overflow (the settings dropdown, organization select) and maybe other places. This is quite and edge case to be honest. Really not a must. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @scopsy yes. this makes sense. done |
||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import { Injectable } from '@nestjs/common'; | ||
import { OrganizationRepository } from '@novu/dal'; | ||
import { UpdateOrganizationCommand } from './update-organization-command'; | ||
|
||
@Injectable() | ||
export class UpdateOrganization { | ||
constructor(private organizationRepository: OrganizationRepository) {} | ||
|
||
async execute(command: UpdateOrganizationCommand) { | ||
const payload = { | ||
name: command.name, | ||
}; | ||
|
||
await this.organizationRepository.updateOrganization(command.id, payload); | ||
|
||
return payload; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add the member role enum here:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. we want to restrict the update to only members of an organisation with role
admin
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes exactly 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scopsy done