Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📡 Replace Provider Identifier with Integration Identifier #5061

Closed
6 tasks
LetItRock opened this issue Jan 9, 2024 · 7 comments
Closed
6 tasks

📡 Replace Provider Identifier with Integration Identifier #5061

LetItRock opened this issue Jan 9, 2024 · 7 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@LetItRock
Copy link
Contributor

LetItRock commented Jan 9, 2024

What?

On the integrations page, we show the provider identifier with each integration

Monosnap Integrations | Novu Manage Platform 2023-11-03 11-12-45.png

Monosnap Integrations | Novu Manage Platform 2023-11-03 11-20-37.png

image.png



Why? (Context)

It should be Integration Identifier because in code there is no any variable with name as providerIdentifier

Instead we have integrationIdentifier variable at many places.
One such use case is to override email/sms provider. Here sendgrid-DqJizp2Zt is Integration Indentifier (or as per image Provider Identifier)

{
 "overrides": {
   "email": {
     "integrationIdentifier": "sendgrid-DqJizp2Zt"
   }
  }
}

Definition of Done

  • The Provider Identifier field name is replaced with Integration identifier field name in UI of an integration settings. See the mock below

    Int. store - Integration store (Figma)

  • The Provider Identifier subtitle+value is replaced with Integration identifier value in the integrations list
    See the mock below

    Int. store - Integration store (Figma)

  • The Provider Identifier hint is displayed on hover over Integration identifier subtitle.

  • The subtitle font is 12px size and 16px line height

    Screenshot 2024-01-04 at 20.20.16.png
  • The copy control is displayed on hover over Integration identifier subtitle

  • By click on identifier it is copied to the clipboard
    See the mock below

    Int. store - Integration store (Figma)

@LetItRock LetItRock added the good first issue Good for newcomers label Jan 9, 2024
Copy link

linear bot commented Jan 9, 2024

@AlexVCS
Copy link
Contributor

AlexVCS commented Jan 9, 2024

hi there, I'd like to work on this issue. can you assign it to me please?

@KaoutharAsma
Copy link

can I work on this ?

@animeshMondal-crypto
Copy link

It is not closed yet, so can i try out this issue??

@LetItRock
Copy link
Contributor Author

hey @AlexVCS! 👋 assigned this ticket to you ;)

@developerdhruv
Copy link

Want to work on it

@ayo6706
Copy link

ayo6706 commented May 7, 2024

Is this still open to being worked on?

@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants