-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NV-3199] feature: add integrationIdentifier field in node sdk #4874
Comments
hi, I'd like to work on this issue. can you assign it to me please? |
Hey @jainpawan21 ,can I work on this issue. Will do a PR soon. Thankyou! |
Sure @AlexVCS I am assigning this to you |
Thanks for your interest. Let me know If you want to work on any other issue |
hey can i work on this issue |
Hi @jainpawan21 , I have raised a PR for this feature. Please look into it and let me know if I missed something |
@Prashant-dot1 |
Why did you let that get merged in then? Aren't you allowing the behavior that's supposedly not allowed according to the guidelines? |
What?
As per this API, While updating credentials of provider for subscriber,
integrationIdentifier
filed can be send to select integration.This field enables to choose for which integration, credentials can be updated
Why? (Context)
Add this new field in nodejs SDK method
setCredentials
Definition of Done
integrationIdentifier
optional field in nodejs SDKsetCredentials
documentation in nodejs readmeFrom SyncLinear.com | NV-3199
The text was updated successfully, but these errors were encountered: