Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NV-3199] feature: add integrationIdentifier field in node sdk #4874

Closed
jainpawan21 opened this issue Nov 19, 2023 · 8 comments · Fixed by #4994
Closed

[NV-3199] feature: add integrationIdentifier field in node sdk #4874

jainpawan21 opened this issue Nov 19, 2023 · 8 comments · Fixed by #4994
Labels
Assigned good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jainpawan21
Copy link
Member

jainpawan21 commented Nov 19, 2023

What?

As per this API, While updating credentials of provider for subscriber, integrationIdentifier filed can be send to select integration.
This field enables to choose for which integration, credentials can be updated

Why? (Context)

Add this new field in nodejs SDK method setCredentials

Definition of Done

  1. Add integrationIdentifier optional field in nodejs SDK
  2. Update setCredentials documentation in nodejs readme
  3. Update this in API reference and corresponding places at documentation

From SyncLinear.com | NV-3199

@jainpawan21 jainpawan21 added good first issue Good for newcomers help wanted Extra attention is needed labels Nov 19, 2023
@AlexVCS
Copy link
Contributor

AlexVCS commented Nov 20, 2023

hi, I'd like to work on this issue. can you assign it to me please?

@namrata18s
Copy link

Hey @jainpawan21 ,can I work on this issue. Will do a PR soon. Thankyou!

@jainpawan21
Copy link
Member Author

Sure @AlexVCS I am assigning this to you

@jainpawan21
Copy link
Member Author

Hey @jainpawan21 ,can I work on this issue. Will do a PR soon. Thankyou!

Thanks for your interest. Let me know If you want to work on any other issue

@dhruvgupta0503
Copy link

hey can i work on this issue

@Prashant-dot1
Copy link
Contributor

Hi @jainpawan21 , I have raised a PR for this feature. Please look into it and let me know if I missed something

@jainpawan21
Copy link
Member Author

@Prashant-dot1
I merged your above PR.
Kindly follow our guidelines. Please ask for issue assignment and wait before starting to work on it if multiple people are interested.
One person was already assigned to this issue and have raised a draft PR

@AlexVCS
Copy link
Contributor

AlexVCS commented Dec 19, 2023

Why did you let that get merged in then? Aren't you allowing the behavior that's supposedly not allowed according to the guidelines?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Assigned good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants