Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NV-2837] 💔 👀 Update UX/UI of the scroll #4261

Closed
LetItRock opened this issue Sep 30, 2023 · 16 comments
Closed

[NV-2837] 💔 👀 Update UX/UI of the scroll #4261

LetItRock opened this issue Sep 30, 2023 · 16 comments
Assignees

Comments

@LetItRock
Copy link
Contributor

What?

Scroll component look and feel

Why? (Context)

It does not look like a part of the application with borders and creates visual clutter.
It also behaves strangely for some pages. Like in the WF editor, it shouldn't appear at all, because there is not so much content. It also does not allow you to scroll down, feels like Novu is frozen :-0

Definition of Done

  • The scroll displays only when the content of a page(section) is bigger than a container of the content (so in the WE it shouldn't appear when the content is fit into the container
  • The scroll uses the same scroll component everywhere
  • The component with 8px height max (see the component in Figma)
  • The visible scroll body is 4px and it's 40% transparent (see the component in Figma)
  • The component background is 100% transparent
  • The scroll should perfectly fit into the container with the scrolling content
  • The scroll sick to the right side of the container

Design:
Workflows / New workflow

@Nitesh123-Nits
Copy link

I want to work on this

@roniskywalker
Copy link

Hello LetItRock, I want to work with this issue. Can you kindly provide a small video about this issue?

@ainouzgali
Copy link
Contributor

Thanks everyone!! @0xprathamesh assigning you

@0xprathamesh 0xprathamesh removed their assignment Oct 1, 2023
@Sahilll15
Copy link

assign this to me

@parag477
Copy link

parag477 commented Oct 1, 2023

Hey, Can you please assign this issue to me?

@harshhere905
Copy link

Hey please assign me this issue

@LetItRock
Copy link
Contributor Author

LetItRock commented Oct 1, 2023

I want to work on this

hey @Nitesh123-Nits, assigned this one to you ;)

@LetItRock
Copy link
Contributor Author

hey @roniskywalker @Sahilll15 @parag477 @harshhere905! 👋
we have many more tickets out here, please take a look at those that are not assigned to anyone :) or find yourself the parts in the code that can be improved :) or you can add some missing tests for api or web apps, we would be really thankful :)

@narendercoder
Copy link

Hey, can you please assign me this issue ?

@RSN601KRI
Copy link

Hey Can you assign me this issue?

@Vriddhi23
Copy link

Hey,I too wanna contibute to this.Can you also assign this to me.

@LetItRock
Copy link
Contributor Author

friends! 👋 we have the assignee in this ticket, but we really appreciate your interest in contributing to the Novu repository :) please take a look at the other tickets we have here ;)

if the assigned person won't be able to publish the PR, we will assign this ticket to someone else in the order from the top ;)

@Isoumyajit
Copy link

Hi I want to work on this @LetItRock , Please assign this to me
Thank you !!

@nick2432
Copy link
Contributor

i wants to work on this please assign it to me

mr-unmole added a commit to mr-unmole/novu that referenced this issue Oct 23, 2023
@mr-unmole
Copy link

@LetItRock I have created a pull request fixing the issue. Please review it as soon as possible.

@mr-unmole
Copy link

@ainouzgali I had made this pull request long ago, can it be reviewed and merged ??

@scopsy scopsy closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests