feat(api): generate preview working as expected

novuhq · Nov 4, 2024 · f7df07f · f7df07f
1 parent 4961657
commit f7df07f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/apps/api/src/app/workflows-v2/generate-preview.e2e.ts b/apps/api/src/app/workflows-v2/generate-preview.e2e.ts
@@ -206,8 +206,11 @@ describe('Generate Preview', () => {
   ): Promise<GeneratePreviewResponseDto> {
     const novuRestResult = await workflowsClient.generatePreview(workflowId, stepDatabaseId, dto);
     if (novuRestResult.isSuccessResult()) {
+      console.log('previewResponseDto.exampleMasterPayload', novuRestResult.value.exampleMasterPayload);
+
       return novuRestResult.value;
     }
+
     throw await assertHttpError(description, novuRestResult);
   }
 
@@ -267,7 +270,7 @@ function buildSimpleForEmail(): EmailStepControlSchemaDto {
 }
 function buildInAppControlValues(): InAppOutput {
   return {
-    subject: `Hello, World! ${PLACEHOLDER_SUBJECT_INAPP}`,
+    subject: `{{subscriber.firstName}} Hello, World! ${PLACEHOLDER_SUBJECT_INAPP}`,
     body: 'Hello, World! {{payload.placeholder.body}}',
     avatar: 'https://www.example.com/avatar.png',
     primaryAction: {

diff --git a/...es/generate-preview/construct-payload-from-placeholders-with-defaults-use-case.service.ts b/...es/generate-preview/construct-payload-from-placeholders-with-defaults-use-case.service.ts
@@ -34,7 +34,7 @@ export class ConstructPayloadFromPlaceholdersWithDefaultsUseCase {
     }
 
     return {
-      augmentedPayload: _.merge(aggregatedDefaultValues, payloadValues),
+      augmentedPayload: _.merge(aggregatedDefaultValues, { payload: payloadValues }),
       issues: this.buildVariableMissingIssueRecord(
         aggregatedDefaultValuesForControl,
         aggregatedDefaultValues,