fix mongodb secret condition and helper (#5534)

novuhq · May 9, 2024 · ea49ccc · ea49ccc
1 parent a9ee4fa
commit ea49ccc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/docker/kubernetes/helm/templates/_helpers.tpl b/docker/kubernetes/helm/templates/_helpers.tpl
@@ -245,12 +245,12 @@ Return mongodb username
 Return mongodb secretName
 */}}
 {{- define "novu.mongodb.secretName" -}}
-{{- if .Values.mongodb.enabled -}}
+{{- if and (not .Values.externalDatabase.existingSecret) (not .Values.mongodb.auth.existingSecret) }}
     {{- printf "%s-url-mongodb" (include "common.names.fullname" .) | trunc 63 | trimSuffix "-" -}}
 {{- else if .Values.externalDatabase.existingSecret -}}
     {{- printf "%s" .Values.externalDatabase.existingSecret -}}
-{{- else -}}
-     {{- printf "%s-externaldb" (include "common.names.fullname" .) | trunc 63 | trimSuffix "-" -}}
+{{- else if .Values.mongodb.auth.existingSecret -}}
+    {{- printf "%s" .Values.mongodb.auth.existingSecret -}}
 {{- end -}}
 {{- end -}}
 

diff --git a/docker/kubernetes/helm/templates/db-secrets.yaml b/docker/kubernetes/helm/templates/db-secrets.yaml
@@ -1,8 +1,7 @@
-{{- if and (not .Values.externalDatabase.existingSecret) (not .Values.mongodb.existingSecret) }}
+{{- if and (not .Values.externalDatabase.existingSecret) (not .Values.mongodb.auth.existingSecret) }}
 apiVersion: v1
 kind: Secret
 metadata:
-
   name: {{ include "novu.mongodb.secretName" . }}
   namespace: {{ include "common.names.namespace" . | quote }}
   labels: {{- include "common.labels.standard" . | nindent 4 }}