Skip to content

Commit

Permalink
chore(root): Use pnpm to resolve workspace protocol during package pr…
Browse files Browse the repository at this point in the history
…eview deployment

See here stackblitz-labs/pkg.pr.new#204 (comment)
  • Loading branch information
SokratisVidros committed Sep 19, 2024
1 parent 762e612 commit d0ce56b
Show file tree
Hide file tree
Showing 13 changed files with 13 additions and 17 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/release-packages-preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@ jobs:
- name: Install dependencies
run: pnpm install

- name: Teach Novu preview packages to work with latest dependencies
run: pnpm run packages:set-latest

- name: Build
run: pnpm run build:affected
if: ${{ success() }}
Expand Down
5 changes: 2 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"release:preminor": "nx release version preminor --no-push",
"release:prerelease": "nx release version prerelease --no-push",
"release:submodules": "ts-node scripts/release-with-submodules.ts",
"release:previews": "nx affected -t release:preview --base=origin/next~1 --head=HEAD --exclude=nextjs",
"release:previews": "nx affected -t release:preview --base=origin/next --head=HEAD --exclude=nextjs",
"start:integration:api": "cd apps/api && pnpm run test",
"start:e2e:api": "cd apps/api && pnpm run test:e2e",
"g:module": "hygen module new --name=$npm_config_name",
Expand All @@ -72,8 +72,7 @@
"get-affected": "node scripts/print-affected-array.mjs",
"symlink:submodules": "pnpm --filter \"@novu/ee-*\" exec node \"$(pwd)/scripts/symlink-ee.mjs\"",
"install:with-ee": "pnpm install && pnpm symlink:submodules",
"packages:set-workspace-protocol": "node scripts/set-package-dependencies.mjs workspace:*",
"packages:set-latest": "node scripts/set-package-dependencies.mjs latest"
"packages:set-workspace-protocol": "node scripts/set-package-dependencies.mjs workspace:*"
},
"devDependencies": {
"@auto-it/npm": "^10.36.5",
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"start:test": "cross-env NODE_ENV=test PORT=1336 nodemon init",
"start:debug": "cross-env nodemon --config nodemon-debug.json",
"start:prod": "cross-env node dist/src/index.js",
"release:preview": "pnpx pkg-pr-new publish"
"release:preview": "pnpx pkg-pr-new --compact --pnpm publish"
},
"keywords": [
"novu",
Expand Down
2 changes: 1 addition & 1 deletion packages/client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"doc:publish": "gh-pages -m \"[ci skip] Updates\" -d build/docs",
"reset-hard": "git clean -dfx && git reset --hard && pnpm install",
"prepare-release": "run-s reset-hard test",
"release:preview": "pnpx pkg-pr-new publish"
"release:preview": "pnpx pkg-pr-new --compact --pnpm publish"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/framework/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"bump:prerelease": "npm version prerelease --preid=alpha & PID=$!; (sleep 1 && kill -9 $PID) & wait $PID",
"release:alpha": "pnpm bump:prerelease || pnpm build && npm publish",
"devtool": "tsx ./scripts/devtool.ts",
"release:preview": "pnpx pkg-pr-new publish"
"release:preview": "pnpx pkg-pr-new --compact --pnpm publish"
},
"keywords": [
"novu",
Expand Down
2 changes: 1 addition & 1 deletion packages/headless/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"lint:fix": "eslint src --fix",
"test": "jest",
"test:watch": "jest --watch",
"release:preview": "pnpx pkg-pr-new publish"
"release:preview": "pnpx pkg-pr-new --compact --pnpm publish"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"lint": "eslint src",
"lint:fix": "pnpm lint -- --fix",
"test": "jest",
"release:preview": "pnpx pkg-pr-new publish"
"release:preview": "pnpx pkg-pr-new --compact --pnpm publish"
},
"browserslist": {
"production": [
Expand Down
2 changes: 1 addition & 1 deletion packages/nest/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"watch:test": "jest src --watch",
"reset-hard": "git clean -dfx && git reset --hard && pnpm install",
"prepare-release": "run-s reset-hard test",
"release:preview": "pnpx pkg-pr-new publish"
"release:preview": "pnpx pkg-pr-new --compact --pnpm publish"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/node/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"doc:publish": "gh-pages -m \"[ci skip] Updates\" -d build/docs",
"reset-hard": "git clean -dfx && git reset --hard && pnpm install",
"prepare-release": "run-s reset-hard test",
"release:preview": "pnpx pkg-pr-new publish"
"release:preview": "pnpx pkg-pr-new --compact --pnpm publish"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/providers/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"watch:test": "vitest",
"reset-hard": "git clean -dfx && git reset --hard && yarn",
"prepare-release": "run-s reset-hard test",
"release:preview": "pnpx pkg-pr-new publish"
"release:preview": "pnpx pkg-pr-new --compact --pnpm publish"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"build": "tsup && pnpm run check-exports",
"lint": "eslint src",
"check-exports": "attw --pack .",
"release:preview": "pnpx pkg-pr-new publish"
"release:preview": "pnpx pkg-pr-new --compact --pnpm publish"
},
"browserslist": {
"production": [
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"lint:fix": "pnpm lint -- --fix",
"test": "jest src",
"watch:test": "jest src --watch",
"release:preview": "pnpx pkg-pr-new publish"
"release:preview": "pnpx pkg-pr-new --compact --pnpm publish"
},
"author": "",
"license": "ISC",
Expand Down
2 changes: 1 addition & 1 deletion packages/stateless/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"doc:publish": "gh-pages -m \"[ci skip] Updates\" -d build/docs",
"reset-hard": "git clean -dfx && git reset --hard && pnpm install",
"prepare-release": "run-s reset-hard test",
"release:preview": "pnpx pkg-pr-new publish"
"release:preview": "pnpx pkg-pr-new --compact --pnpm publish"
},
"publishConfig": {
"access": "public"
Expand Down

0 comments on commit d0ce56b

Please sign in to comment.