fix(framework): Ensure missing schemas return unknown record type (#6912

)
novuhq · Nov 11, 2024 · b9185ed · b9185ed
1 parent f5af1d4
commit b9185ed
Show file tree

Hide file tree

Showing 61 changed files with 981 additions and 544 deletions.
diff --git a/...ronments-v1/usecases/construct-framework-workflow/construct-framework-workflow.usecase.ts b/...ronments-v1/usecases/construct-framework-workflow/construct-framework-workflow.usecase.ts
@@ -5,6 +5,7 @@ import {
   ChannelStep,
   DelayOutput,
   DigestOutput,
+  JsonSchema,
   Step,
   StepOptions,
   StepOutput,
@@ -41,10 +42,10 @@ export class ConstructFrameworkWorkflow {
       }
     }
 
-    return this.constructFrameworkWorkflow(dbWorkflow, command.action);
+    return this.constructFrameworkWorkflow(dbWorkflow);
   }
 
-  private constructFrameworkWorkflow(newWorkflow, action) {
+  private constructFrameworkWorkflow(newWorkflow: NotificationTemplateEntity) {
     return workflow(
       newWorkflow.triggers[0].identifier,
       async ({ step, payload, subscriber }) => {
@@ -178,7 +179,8 @@ export class ConstructFrameworkWorkflow {
 
   private constructCommonStepOptions(staticStep: NotificationStepEntity): Required<StepOptions> {
     return {
-      controlSchema: staticStep.template!.controls!.schema,
+      // TODO: fix the `JSONSchemaDto` type to enforce a non-primitive schema type.
+      controlSchema: staticStep.template!.controls!.schema as JsonSchema,
       /*
        * TODO: add conditions
        * Used to construct conditions defined with https://react-querybuilder.js.org/ or similar

diff --git a/packages/framework/package.json b/packages/framework/package.json
@@ -25,7 +25,7 @@
     "next",
     "nuxt",
     "remix",
-    "sveltekit",  
+    "sveltekit",
     "README.md"
   ],
   "scripts": {

diff --git a/packages/framework/src/client.ts b/packages/framework/src/client.ts
@@ -222,7 +222,7 @@ export class Client {
           throw new Error(`Invalid component: '${component}'`);
       }
     } else {
-      return result.data;
+      return result.data as T;
     }
   }