refactor(errors): move isNativeError function

novuhq · Nov 8, 2024 · a6b6060 · a6b6060
1 parent 82d980e
commit a6b6060
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 22 deletions.
diff --git a/packages/framework/src/errors/base.errors.ts b/packages/framework/src/errors/base.errors.ts
@@ -1,6 +1,24 @@
 import { HttpStatusEnum } from '../constants';
 import { ErrorCodeEnum } from '../constants/error.constants';
-import { isNativeError } from './guard.errors';
+
+/**
+ * Check if the object is a native error.
+ *
+ * This method relies on `Object.prototype.toString()` behavior. It is possible to obtain
+ * an incorrect result when the object argument manipulates the `@@toStringTag` property.
+ *
+ * @param object - The object to check.
+ * @returns `true` if the object is a native error, `false` otherwise.
+ */
+export const isNativeError = (object: unknown): object is Error => {
+  if (typeof object !== 'object' || object === null) {
+    return false;
+  }
+
+  const proto = Object.getPrototypeOf(object);
+
+  return proto?.constructor?.name.endsWith('Error') ?? false;
+};
 
 /**
  * Base error class.

diff --git a/packages/framework/src/errors/guard.errors.test.ts b/packages/framework/src/errors/guard.errors.test.ts
@@ -1,8 +1,8 @@
 import { expect, it, describe } from 'vitest';
-import { isFrameworkError, isNativeError, isPlatformError } from './guard.errors';
+import { isFrameworkError, isPlatformError } from './guard.errors';
+import { isNativeError, FrameworkError } from './base.errors';
 import { PlatformError } from './platform.errors';
 import { ErrorCodeEnum, HttpStatusEnum } from '../constants';
-import { FrameworkError } from './base.errors';
 import { BridgeError } from './bridge.errors';
 
 class TestFrameworkError extends FrameworkError {

diff --git a/packages/framework/src/errors/guard.errors.ts b/packages/framework/src/errors/guard.errors.ts
@@ -2,25 +2,6 @@ import { ErrorCodeEnum } from '../constants';
 import { FrameworkError } from './base.errors';
 import { PlatformError } from './platform.errors';
 
-/**
- * Check if the object is a native error.
- *
- * This method relies on `Object.prototype.toString()` behavior. It is possible to obtain
- * an incorrect result when the object argument manipulates the `@@toStringTag` property.
- *
- * @param object - The object to check.
- * @returns `true` if the object is a native error, `false` otherwise.
- */
-export const isNativeError = (object: unknown): object is Error => {
-  if (typeof object !== 'object' || object === null) {
-    return false;
-  }
-
-  const proto = Object.getPrototypeOf(object);
-
-  return proto?.constructor?.name.endsWith('Error') ?? false;
-};
-
 /**
  * Check if the error is a `FrameworkError`.
  *