-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(design-system,web): Move icons (#5677)
* feat: Add react-icons * docs: Deprecate all the things! * refactor: Move icons export to `@novu/novui/icons`
- Loading branch information
Joel Anton
authored
Jun 4, 2024
1 parent
9de2dcb
commit 9d4d28d
Showing
18 changed files
with
17,910 additions
and
354 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,28 +1,44 @@ | ||
import { CSSProperties, SVGAttributes } from 'react'; | ||
|
||
/** Icon Size in pixels (to be replaced with values directly from Design System) */ | ||
/** | ||
* @deprecated Use @novu/novui/icons instead. | ||
* Icon Size in pixels (to be replaced with values directly from Design System) | ||
*/ | ||
export type IconSize = '16' | '20' | '24'; | ||
|
||
/** A temporary type that accepts a typical CSS color until we have our strict Design System types defined */ | ||
/** | ||
* @deprecated Use @novu/novui/icons instead. | ||
* A temporary type that accepts a typical CSS color until we have our strict Design System types defined | ||
*/ | ||
type UnsafeIconColor = CSSProperties['color']; | ||
|
||
/** @deprecated Use @novu/novui/icons instead. */ | ||
export interface IIconStyleProps { | ||
/** | ||
* | ||
* @deprecated Use @novu/novui/icons instead. | ||
* Default: '20px'. | ||
* | ||
* The actual display size in pixels. | ||
*/ | ||
size?: IconSize; | ||
/** | ||
* | ||
* @deprecated Use @novu/novui/icons instead. | ||
* Default: B60 | ||
* | ||
* WARNING: this is only to be used with colors from the design system, and will later be enforced more strictly | ||
*/ | ||
color?: UnsafeIconColor; | ||
} | ||
|
||
/** @deprecated Use @novu/novui/icons instead. */ | ||
export interface IIconProps extends Omit<SVGAttributes<SVGElement>, 'color'>, IIconStyleProps { | ||
/** Description for accessibility. This is mandatory so that we make a11y a priority with icons */ | ||
/** | ||
* Description for accessibility. This is mandatory so that we make a11y a priority with icons | ||
*/ | ||
title: string; | ||
} | ||
|
||
/** @deprecated Use @novu/novui/icons instead. */ | ||
export type IconType = (props: IIconProps) => JSX.Element; |
Oops, something went wrong.