fix(actions): Restore stricter checks for slack notifications

novuhq · May 9, 2024 · 9634523 · 9634523
1 parent c89e954
commit 9634523
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/.github/actions/slack-notify-on-failure/action.yml b/.github/actions/slack-notify-on-failure/action.yml
@@ -16,6 +16,6 @@ runs:
         message_format: "{emoji} *{workflow}* {status_message} in <{repo_url}|{repo}>"
         notification_title: "{workflow} is now failing!"
         notify_when: "failure"
-        status: "failure"
+        status: ${{ job.status }}
       env:
         SLACK_WEBHOOK_URL: ${{ inputs.slackWebhookURL }}
diff --git a/.github/workflows/reusable-web-e2e.yml b/.github/workflows/reusable-web-e2e.yml
@@ -235,6 +235,6 @@ jobs:
           path: apps/web/cypress/screenshots
 
       - uses: ./.github/actions/slack-notify-on-failure
-        if: failure()
+        if: ${{ failure() || needs.e2e_web.result == 'failure' }}
         with:
           slackWebhookURL: ${{ secrets.SLACK_WEBHOOK_URL_ENG_FEED_GITHUB }}